Address review feedback: Add warning checks, extract shared variables, remove redundant tests

Co-authored-by: posva <[email protected]>

Author: Copilot

src/core/definePage.spec.ts

@@ -1,6 +1,7 @@
 import { TransformResult } from 'vite'
 import { expect, describe, it } from 'vitest'
 import { definePageTransform, extractDefinePageNameAndPath } from './definePage'
+import { mockWarn } from '../../tests/vitest-mock-warn'
 
 const sampleCode = `
 <script setup>
@@ -18,6 +19,7 @@ const b = 1
       `
 
 describe('definePage', () => {
+  mockWarn()
   it('removes definePage', async () => {
     const result = (await definePageTransform({
       code: sampleCode,
@@ -256,8 +258,7 @@ export default {
   })
 
   describe('error handling', () => {
-    it('handles syntax errors gracefully when extracting definePage', async () => {
-      const codeWithSyntaxError = `
+    const codeWithSyntaxError = `
 <script setup>
 definePage({
   name: 'test',,  // syntax error: extra comma
@@ -270,17 +271,19 @@ definePage({
 </template>
       `
 
+    it('handles syntax errors gracefully when extracting definePage', async () => {
       const result = await definePageTransform({
         code: codeWithSyntaxError,
         id: 'src/pages/broken.vue?definePage&vue',
       })
 
       // Should return empty object instead of crashing
       expect(result).toBe('export default {}')
+      expect('Failed to process definePage:').toHaveBeenWarned()
     })
 
     it('handles syntax errors gracefully when removing definePage from source', async () => {
-      const codeWithSyntaxError = `
+      const codeForRemoval = `
 <script setup>
 const a = 1
 definePage({
@@ -296,68 +299,24 @@ const b = 1
       `
 
       const result = await definePageTransform({
-        code: codeWithSyntaxError,
+        code: codeForRemoval,
         id: 'src/pages/broken.vue',
       })
 
       // Should return undefined (no transform) instead of crashing
       expect(result).toBeUndefined()
-    })
-
-    it('handles malformed definePage object gracefully', async () => {
-      const codeWithMalformedObject = `
-<script setup>
-definePage({
-  name: 'test'
-  path: '/test'  // missing comma
-})
-</script>
-      `
-
-      const result = await definePageTransform({
-        code: codeWithMalformedObject,
-        id: 'src/pages/malformed.vue?definePage&vue',
-      })
-
-      expect(result).toBe('export default {}')
-    })
-
-    it('handles completely invalid JavaScript syntax gracefully', async () => {
-      const codeWithInvalidSyntax = `
-<script setup>
-definePage({
-  name: 'test',
-  path: '/test'
-  invalid javascript syntax here ###
-})
-</script>
-      `
-
-      const result = await definePageTransform({
-        code: codeWithInvalidSyntax,
-        id: 'src/pages/invalid.vue?definePage&vue',
-      })
-
-      expect(result).toBe('export default {}')
+      expect('Failed to process definePage:').toHaveBeenWarned()
     })
 
     it('handles extractDefinePageNameAndPath with syntax errors gracefully', async () => {
-      const codeWithSyntaxError = `
-<script setup>
-definePage({
-  name: 'test',,  // syntax error: extra comma
-  path: '/test'
-})
-</script>
-      `
-
       const result = await extractDefinePageNameAndPath(
         codeWithSyntaxError,
         'src/pages/broken.vue'
       )
 
       // Should return null/undefined instead of crashing
       expect(result).toBeUndefined()
+      expect('Failed to extract definePage info:').toHaveBeenWarned()
     })
 
     it('handles unclosed brackets in definePage gracefully', async () => {
@@ -376,6 +335,7 @@ definePage({
       })
 
       expect(result).toBe('export default {}')
+      expect('Failed to process definePage:').toHaveBeenWarned()
     })
   })
 })