Remove "paper" as default reference when adding annotations/shapes/images #1888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pin black version in pre-commit-config.yaml
don't support setting row/col to "paper", instead use xref/yref="paper"
Contributor
|
@emmanuelle this resolves this issues you raised right? 💃 from me if so! |
Contributor
|
Yes, looks good ! 💃 I might have to update the doc tutorial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
add_annotations/add_shapes/add_imagesso that if norow/colare specified, thexref/yrefproperties are left unset rather than being set to"paper". Now, to useadd_annotationsto add an annotation in "paper" coordinates you leaverow/colunset and simply passxref="paper" and yref="paperkwargs.Similarly,
select_annotationsno longer acceptsrow="paper"/col="paper. Instead, to select only the annotations in paper coordinates, you would usexref="paper",yref="paper"in theselector.@nicolaskruchten
Closes #1881