New lint rule to disallow named function expressions

[archmoj]

A follow up of #3162, #3162 (comment) and the discussion with @etpinard concerning redundant and sometime confusing function names this PR adds a new lint rule to disallow extra function names when they are not required. Image below illustrates one example where the function is named put and exported as get.

plotly.js/src/traces/bar/sieve.js

Line 87 in d2f8976

Sieve.prototype.get = function put(position, value) {

@plotly/plotly_js

[etpinard]

Ah ooops. I think I might have unestimated what adding this new rule meant this morning (in-person convo)

I very much dislike removing the function names from things we export off module.exports e.g.:

[etpinard]

@archmoj maybe https://eslint.org/docs/rules/func-name-matching would give better results.

[archmoj]

@archmoj maybe https://eslint.org/docs/rules/func-name-matching would give better results.

Awesome! That one was able to detect the mismatches: 6d1609a.

[etpinard]

Ok. Nicely done 💃