chore(upgrade): update short period time #463
Conversation
gezerui0124
requested review from
0xHansLee,
AndyBoWu,
LeoHChen,
edisonz0718,
jdubpark,
leeren and
limengformal
as code owners
| UpgradeName = "singularity_v1" | ||
|
|
||
| // UpgradeHeight defines the block height at which the Story singularity v1 upgrade is triggered. | ||
| UpgradeHeight = 1_000_000 |
There was a problem hiding this comment.
@limengformal @edisonz0718 plz confirm upgrade height
There was a problem hiding this comment.
updated in 28cbf48
| NewShortPeriodDuration = time.Second * 7776000 // 90 days | ||
|
|
||
| // SingularityHeight defines the block height at which the Story singularity period ends. | ||
| NewSingularityHeight = 1_500_000 |
There was a problem hiding this comment.
@limengformal @edisonz0718 plz confirm new singularity height
There was a problem hiding this comment.
updated in 28cbf48
gezerui0124
force-pushed
the
rayden/singularity-upgrade
branch
from
59e5d68 to
a231b51
Compare
| case upgrades.StoryChainID: | ||
| return StoryUpgradeHeight, true | ||
| default: | ||
| return 0, false |
There was a problem hiding this comment.
Should it panic here? If there is another chain case, it's better to add explicitly.
There was a problem hiding this comment.
I used to perform panic here, but I thought there maybe some other networks for testing in the future, then we may need to change the logic here.
Current way seems more scalable.
There was a problem hiding this comment.
We can add a local flag for testing later. Also people can branch it out and modify the code if they want to create a custom network. Meanwhile leaving the node running if the chain id is not found seem to be a more risky option.
| case upgrades.StoryChainID: | ||
| return NewStorySingularityHeight, true | ||
| default: | ||
| return 0, false |
There was a problem hiding this comment.
Should It panic here? If there is another chain case, it's better to add explicitly
There was a problem hiding this comment.
I used to perform panic here, but I thought there maybe some other networks for testing in the future, then we may need to change the logic here.
Current way seems more scalable.
|
|
||
| const ( | ||
| // UpgradeName defines the on-chain upgrade name for the singularity v1 upgrade. | ||
| UpgradeName = "singularity_v1" |
There was a problem hiding this comment.
We may want to name it virgil or v1.1.0
There was a problem hiding this comment.
May also want to change folder name v1 to virgil or v1.1.0
chore(upgrade): change upgrade name
gezerui0124
force-pushed
the
rayden/singularity-upgrade
branch
from
b485135 to
99e8702
Compare
Binary uploaded successfully 🎉📦 Version Name: 1.1.0-unstable-0e98d46 |
gezerui0124
changed the title
…abs#463) update singularity height and short period time issue: none
update singularity height and short period time
issue: none