Skip to content

Commit d3a5a44

Browse files
authored
fix: removing returning proper client id for cli (#54)
1 parent 69689d5 commit d3a5a44

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

apps/event-system/services/users/users.service.ts

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -333,9 +333,7 @@ module.exports = {
333333
'Accept-Encoding': 'UTF-8',
334334
},
335335
params: {
336-
client_id: ctx.meta.isAdmin
337-
? process.env.ADMIN_GITHUB_OAUTH_CLIENT_ID
338-
: process.env.GITHUB_OAUTH_CLIENT_ID,
336+
client_id: this.getClientId(isTerminal, ctx.meta.isAdmin),
339337
client_secret: this.getClientSecret(
340338
isTerminal,
341339
ctx.meta.isAdmin
@@ -922,6 +920,11 @@ module.exports = {
922920
if (isAdmin) return process.env.ADMIN_GITHUB_OAUTH_CLIENT_SECRET;
923921
return process.env.GITHUB_OAUTH_CLIENT_SECRET;
924922
},
923+
getClientId(isTerminal: boolean, isAdmin: boolean) {
924+
if (isTerminal) return process.env.GITHUB_OAUTH_CLIENT_CLI_ID;
925+
if (isAdmin) return process.env.ADMIN_GITHUB_OAUTH_CLIENT_ID;
926+
return process.env.GITHUB_OAUTH_CLIENT_ID;
927+
},
925928
async createOrUpdateUser({
926929
ctx,
927930
provider,

0 commit comments

Comments
 (0)