ISSUE-345: PantherTestCase in ci

Author: tatevikg1

.github/workflows/ci.yml

@@ -37,6 +37,16 @@ jobs:
           curl -sS https://get.symfony.com/cli/installer | bash
           mv $HOME/.symfony*/bin/symfony /usr/local/bin/symfony
           symfony version
+      - name: Install Google Chrome
+        run: |
+          curl -sSL https://dl.google.com/linux/linux_signing_key.pub | gpg --dearmor | sudo tee /usr/share/keyrings/google.gpg > /dev/null
+          echo "deb [arch=amd64 signed-by=/usr/share/keyrings/google.gpg] http://dl.google.com/linux/chrome/deb/ stable main" | sudo tee /etc/apt/sources.list.d/google-chrome.list
+          sudo apt-get update
+          sudo apt-get install -y google-chrome-stable
+      - name: Set Panther to use Chrome
+        run: |
+          echo "PANTHER_NO_HEADLESS=0" >> .env.test
+          echo "PANTHER_CHROME_BINARY=/usr/bin/google-chrome" >> .env.test
       - name: Start mysql service
         run: sudo /etc/init.d/mysql start
       - name: Verify MySQL connection on host

.gitignore

@@ -16,3 +16,4 @@
 .phpunit.result.cache
 .env
 /node_modules
+/drivers/

composer.json

@@ -44,7 +44,8 @@
         "phpmd/phpmd": "^2.9.1",
         "symfony/process": "^6.4",
         "symfony/panther": "*",
-        "dbrekelmans/bdi": "*"
+        "dbrekelmans/bdi": "*",
+        "bshaffer/phpunit-retry-annotations": "^0.3.0"
     },
     "autoload": {
         "psr-4": {

tests/Integration/Auth/LoginTest.php

@@ -4,30 +4,27 @@
 
 namespace PhpList\WebFrontend\Tests\Integration\Auth;
 
+use PHPUnitRetry\RetryAnnotationTrait;
+use PHPUnitRetry\RetryTrait;
 use Symfony\Component\Panther\PantherTestCase;
-use Symfony\Component\Panther\Client;
 
+/**
+ * @retryAttempts 5
+ * @retryIfException Facebook\WebDriver\Exception\NoSuchWindowException
+ * @retryDelaySeconds 10
+ */
 class LoginTest extends PantherTestCase
 {
-    protected static ?Client $client = null;
+    use RetryAnnotationTrait;
+    use RetryTrait;
 
-    public function setUp(): void
+    public function testLoginPageFormFieldsAreVisible(): void
     {
-        parent::setUp();
-        self::$client = static::createPantherClient([
+        $client = static::createPantherClient([
             'browser' => static::CHROME,
+            'connection_timeout_in_ms' => 10000,
         ]);
-    }
-
-    public function tearDown(): void
-    {
-        self::$client?->quit();
-        parent::tearDown();
-    }
-
-    public function testLoginPageFormFieldsAreVisible(): void
-    {
-        self::$client->request('GET', '/app_test.php/login');
+        $client->request('GET', '/app_test.php/login');
 
         $this->assertPageTitleContains('phpList - Login');
 
@@ -45,9 +42,13 @@ public function testLoginPageFormFieldsAreVisible(): void
 
     public function testLoginFormSubmission(): void
     {
-        self::$client->request('GET', '/app_test.php/login');
+        $client = static::createPantherClient([
+            'browser' => static::CHROME,
+            'connection_timeout_in_ms' => 20000,
+        ]);
+        $client->request('GET', '/app_test.php/login');
 
-        self::$client->submitForm('Sign in', [
+        $client->submitForm('Sign in', [
             'username' => 'invalid_user',
             'password' => 'invalid_password'
         ]);

tests/Unit/Controller/AuthControllerTest.php

@@ -119,7 +119,7 @@ public function testLoginWithPostRequestSuccess(): void
         $request->setSession($session);
 
         $this->apiClient->method('authenticate')
-            ->with('admin', 'secret')
+            ->with('testuser', 'testpass')
             ->willReturn(['key' => 'test-token']);
 
         $this->apiClient->expects($this->once())
@@ -128,7 +128,8 @@ public function testLoginWithPostRequestSuccess(): void
 
         $response = $this->controller->login($request);
 
-        $this->assertInstanceOf(Response::class, $response);
+        $this->assertInstanceOf(RedirectResponse::class, $response);
+        $this->assertStringContainsString('empty_start_page', $response->getTargetUrl());
     }
 
     public function testLoginWithPostRequestFailure(): void
@@ -147,7 +148,7 @@ public function testLoginWithPostRequestFailure(): void
         $request->setSession($session);
 
         $this->apiClient->method('authenticate')
-            ->with('testuser', 'wrongpass')
+            ->with('testuser', 'testpass')
             ->willThrowException(new RuntimeException('Invalid credentials'));
 
         $response = $this->controller->login($request);