After review 1

tatevikg1 · tatevikg1 · commit aa4b93865bba · 2025-11-04T11:04:51.000+04:00
diff --git a/config/parameters.yml.dist b/config/parameters.yml.dist
@@ -87,4 +87,4 @@ parameters:
     env(MESSAGING_MAX_PROCESS_TIME): '600'
 
     phplist.admin.password: '%%env(PHPLIST_ADMIN_PASSWORD)%%'
-    env(PHPLIST_ADMIN_PASSWORD): 'password'
+    env(PHPLIST_ADMIN_PASSWORD): ''
diff --git a/src/Migrations/Version20251103SeedInitialAdmin.php b/src/Migrations/Version20251103SeedInitialAdmin.php
@@ -40,6 +40,8 @@ public function up(Schema $schema): void
             $password = getenv('PHPLIST_ADMIN_PASSWORD') ?: '';
         }
 
+        $this->abortIf(trim($password) === '', 'Set PHPLIST_ADMIN_PASSWORD before running this migration.');
+
         $this->addSql(<<<'SQL'
     INSERT INTO phplist_admin (id, created, modified, loginname, namelc, email, password, passwordchanged, disabled, superuser, privileges)
     VALUES (1, NOW(), NOW(), 'admin', 'admin', 'admin@example.com', :hash, CURRENT_DATE, FALSE, TRUE, :privileges)

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,8 @@ public function up(Schema $schema): void`
`40`	`40`	`$password = getenv('PHPLIST_ADMIN_PASSWORD') ?: '';`
`41`	`41`	`}`
`42`	`42`
	`43`	`+ $this->abortIf(trim($password) === '', 'Set PHPLIST_ADMIN_PASSWORD before running this migration.');`
	`44`	`+`
`43`	`45`	`$this->addSql(<<<'SQL'`
`44`	`46`	`INSERT INTO phplist_admin (id, created, modified, loginname, namelc, email, password, passwordchanged, disabled, superuser, privileges)`
`45`	`47`	`VALUES (1, NOW(), NOW(), 'admin', 'admin', '[email protected]', :hash, CURRENT_DATE, FALSE, TRUE, :privileges)`