feat: Allow any normalizable result from a tool

Author: valtzu

src/Chain/Toolbox/ToolResultConverter.php

@@ -4,32 +4,43 @@
 
 namespace PhpLlm\LlmChain\Chain\Toolbox;
 
+use Symfony\Component\Serializer\Encoder\EncoderInterface;
+use Symfony\Component\Serializer\Encoder\JsonEncoder;
+use Symfony\Component\Serializer\Normalizer\DateTimeNormalizer;
+use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
+use Symfony\Component\Serializer\Serializer;
+
 /**
  * @author Christopher Hertel <[email protected]>
  */
 final readonly class ToolResultConverter
 {
-    /**
-     * @param \JsonSerializable|\Stringable|array<int|string, mixed>|float|string|null $result
-     */
-    public function convert(\JsonSerializable|\Stringable|array|float|string|\DateTimeInterface|null $result): ?string
+    public function __construct(
+        private NormalizerInterface&EncoderInterface $serializer = new Serializer([new DateTimeNormalizer(), new ObjectNormalizer()], [new JsonEncoder()]),
+    ) {
+    }
+
+    public function convert(mixed $result): ?string
     {
-        if (null === $result) {
-            return null;
+        if (null === $result || \is_string($result)) {
+            return $result;
         }
 
         if ($result instanceof \JsonSerializable || \is_array($result)) {
             return json_encode($result, flags: \JSON_THROW_ON_ERROR);
         }
 
-        if (\is_float($result) || $result instanceof \Stringable) {
+        if ($result instanceof \Stringable) {
             return (string) $result;
         }
 
-        if ($result instanceof \DateTimeInterface) {
-            return $result->format(\DATE_ATOM);
+        $normalized = $this->serializer->normalize($result, 'json');
+
+        if (\is_scalar($normalized)) {
+            return (string) $normalized;
         }
 
-        return $result;
+        return $this->serializer->encode($normalized, 'json');
     }
 }

tests/Chain/Toolbox/ToolResultConverterTest.php

@@ -5,6 +5,7 @@
 namespace PhpLlm\LlmChain\Tests\Chain\Toolbox;
 
 use PhpLlm\LlmChain\Chain\Toolbox\ToolResultConverter;
+use PhpLlm\LlmChain\Tests\Fixture\StructuredOutput\UserWithConstructor;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\Test;
@@ -55,5 +56,16 @@ public function jsonSerialize(): array
             },
             '{"key":"value"}',
         ];
+
+        yield 'object' => [
+            new UserWithConstructor(
+                id: 123,
+                name: 'John Doe',
+                createdAt: new \DateTimeImmutable('2021-07-31 12:34:56'),
+                isActive: true,
+                age: 18,
+            ),
+            '{"id":123,"name":"John Doe","createdAt":"2021-07-31T12:34:56+00:00","isActive":true,"age":18}',
+        ];
     }
 }