Skip to content

Commit 45dbf21

Browse files
bwl21Uzlopak
authored andcommitted
see #2137 improve reporting of version (#2138)
* see #2137 improve reporting of version 1. get version by git describe 2. fix display of version in jsPDF 3. fix display of version in index.html * Update build.js * Update jspdf.js * Update build.js * Update build.js
1 parent f62d8dd commit 45dbf21

File tree

3 files changed

+24
-22
lines changed

3 files changed

+24
-22
lines changed

build.js

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
'use strict'
22

3-
43
var fs = require('fs')
54
const rollup = require('rollup');
65
const rollupConfig = require('./rollup.config');
@@ -51,13 +50,12 @@ function bundle(options) {
5150
code = code.replace(
5251
/Permission\s+is\s+hereby\s+granted[\S\s]+?IN\s+THE\s+SOFTWARE\./,
5352
'Licensed under the MIT License'
54-
)
53+
);
5554
code = code.replace(
5655
/Permission\s+is\s+hereby\s+granted[\S\s]+?IN\s+THE\s+SOFTWARE\./g,
5756
''
58-
)
59-
60-
code = renew(code);
57+
);
58+
code = renew(code);
6159
fs.writeFileSync(options.distFolder + '/' + options.filename + '.debug.js', code)
6260

6361
console.log('Finish Bundling ' + options.distFolder + '/' + options.filename + '.debug.js');
@@ -77,17 +75,19 @@ function bundle(options) {
7775
}
7876

7977
function renew(code) {
80-
var date = new Date().toISOString()
81-
var version = require('./package.json').version
82-
var whoami = execSync('whoami').toString().trim()
78+
var date = new Date().toISOString();
79+
var version = require('./package.json').version;
80+
var whoami = 'anonymous';
8381
var commit = '00000000';
8482
try {
85-
commit = execSync('git rev-parse --short=10 HEAD').toString().trim()
83+
commit = execSync('git rev-parse --short=10 HEAD').toString().trim();
84+
version = execSync('git describe').toString().trim();
85+
version = version.substring(1, test.indexOf('-'));
86+
whoami = execSync('whoami').toString().trim();
8687
} catch (e) {}
87-
code = code.replace(/\$\{versionID\}/g, version)
88-
code = code.replace(/\$\{builtOn\}/g, date)
89-
code = code.replace('${commitID}', commit)
90-
code = code.replace(/1\.0\.0-trunk/, version + ' ' + date + ':' + whoami)
91-
88+
code = code.replace(/jsPDF.version = '0.0.0'/g, "jsPDF.version = '" + version + "'");
89+
code = code.replace(/\$\{builtOn\}/g, date);
90+
code = code.replace('${commitID}', commit);
91+
code = code.replace(/1\.0\.0-trunk/, version + ' ' + date + ':' + whoami);
9292
return code
9393
}

index.html

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,17 +19,19 @@
1919
<div class="container">
2020

2121
<div class="masthead">
22-
<div class="pull-right">
23-
<div class="tweet-buttons">
22+
<div class="pull-right" style="text-align: right;">
23+
<span class="tweet-buttons">
2424
<a href="https://twitter.com/share" class="twitter-share-button" data-via="MrRio" data-size="large">Tweet</a>
2525
<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
2626
<a href="https://twitter.com/MrRio" class="twitter-follow-button" data-show-count="false" data-size="large">Follow @MrRio</a>
27-
<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
28-
</div>
27+
<a class="btn btn-primary btn-sm" style="vertical-align:top;" href="https://github.com/MrRio/jsPDF">Download Now</a>
28+
<br/><span class="muted" id="dversion"></span>
29+
</span>
30+
<script>!function(d,s,id){var js,fjs=d.getElementsByTagName(s)[0];if(!d.getElementById(id)){js=d.createElement(s);js.id=id;js.src="//platform.twitter.com/widgets.js";fjs.parentNode.insertBefore(js,fjs);}}(document,"script","twitter-wjs");</script>
31+
2932
<!--a class="btn btn-primary btn-large" href="http://jspdf.com/downloads/jsPDF-0.9.0rc2.zip">Download Now</a>
3033
<p class="muted" style="text-align: right;">Version 0.9.0rc2</p-->
31-
<a class="btn btn-primary btn-large" href="https://github.com/MrRio/jsPDF">Download Now</a>
32-
<p class="muted" style="text-align: right;" id="dversion">Version 0.9.0rc2</p>
34+
3335
</div>
3436
<h1 class="muted">jsPDF</h1>
3537
<h4>HTML5 JavaScript PDF generation library from <a href="http://twitter.com/MrRio">@MrRio</a> at <a href="http://parall.ax">Parallax</a></h4>

src/jspdf.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3300,10 +3300,10 @@ var jsPDF = (function (global) {
33003300
/**
33013301
* The version of jsPDF
33023302
* @name version
3303-
* @type {number}
3303+
* @type {string}
33043304
* @memberOf jsPDF
33053305
*/
3306-
jsPDF.version = ("${versionID}" === ("${vers" + "ionID}")) ? "0.0.0" : "${versionID}";
3306+
jsPDF.version = '0.0.0';
33073307

33083308
if (typeof define === 'function' && define.amd) {
33093309
define('jsPDF', function () {

0 commit comments

Comments
 (0)