Switch back to full item yaml text diffs (#2655)

Since we removed the per-attribute signal rendering, this can go back to
the more detailed text diffs over the whole yaml. This provides more
information and has been bugging me since we changed it. This should
also reduce the overall text size of the PR Comment and email
notifications.

GitOrigin-RevId: 973c988a8b59ceefa9ea558f52eafa25febaa3a4

Author: DavidS-ovm

sdp-go/util.go

@@ -2,9 +2,7 @@ package sdp
 
 import (
 	"fmt"
-	"maps"
 	"math"
-	"slices"
 	"strings"
 
 	"github.com/google/uuid"
@@ -84,61 +82,6 @@ func (a *AdapterMetadataList) Register(metadata *AdapterMetadata) *AdapterMetada
 	return metadata
 }
 
-// flatten the data map, so that we can use it to compare the attributes of two
-// items. It will recursively flatten the map and return a new map with the
-// flattened data.
-func flatten(data map[string]any) map[string]any {
-	flattened := make(map[string]any)
-	for k, v := range data {
-		switch v := v.(type) {
-		case map[string]any:
-			for subK, subV := range flatten(v) {
-				flattened[k+"."+subK] = subV
-			}
-		default:
-			flattened[k] = v
-		}
-	}
-	return flattened
-}
-
-// RenderItemDiff generates a diff between two items
-func RenderItemDiff(before, after map[string]any) string {
-	flatB := flatten(before)
-	flatA := flatten(after)
-
-	allKeys := slices.Collect(maps.Keys(flatB))
-	allKeys = slices.AppendSeq(allKeys, maps.Keys(flatA))
-
-	slices.Sort(allKeys)
-	allKeys = slices.Compact(allKeys)
-
-	// allKeys now contains every attribute present in either the before or
-	// after, so we can iterate over it to generate the diff and append stats.
-	para := []string{}
-	for _, key := range allKeys {
-		beforeValue, beforeExists := flatB[key]
-		afterValue, afterExists := flatA[key]
-
-		beforeValueStr := fmt.Sprintf("%v", beforeValue)
-		afterValueStr := fmt.Sprintf("%v", afterValue)
-
-		if beforeExists && afterExists {
-			if beforeValueStr != afterValueStr {
-				// This is an update
-				para = append(para, fmt.Sprintf("- %s: %s\n+ %s: %s", key, beforeValueStr, key, afterValueStr))
-			}
-		} else if beforeExists && !afterExists {
-			// This is a deletion
-			para = append(para, fmt.Sprintf("- %s: %s", key, beforeValueStr))
-		} else if !beforeExists && afterExists {
-			// This is a creation
-			para = append(para, fmt.Sprintf("+ %s: %s", key, afterValueStr))
-		}
-	}
-	return strings.Join(para, "\n")
-}
-
 type RoutineRollUp struct {
 	ChangeId uuid.UUID
 	Gun      string

sdp-go/util_test.go

@@ -64,70 +64,6 @@ func TestCalculatePaginationOffsetLimit(t *testing.T) {
 	})
 }
 
-func TestItemDiffParagraphRendering(t *testing.T) {
-	t.Parallel()
-
-	// table driven tests for rendering item diffs
-	tests := []struct {
-		Name                  string
-		Before                map[string]any
-		After                 map[string]any
-		ExpectedDiffParagraph string
-	}{
-		{
-			Name: "no changes",
-			Before: map[string]any{
-				"name": "test",
-				"age":  30,
-			},
-			After: map[string]any{
-				"name": "test",
-				"age":  30,
-			},
-			ExpectedDiffParagraph: "",
-		},
-		{
-			Name: "update changes",
-			Before: map[string]any{
-				"name": "test",
-				"age":  30,
-			},
-			After: map[string]any{
-				"name": "updated",
-				"age":  30,
-			},
-			ExpectedDiffParagraph: "- name: test\n+ name: updated",
-		},
-		{
-			Name: "nested map",
-			Before: map[string]any{
-				"name": map[string]any{
-					"first": "test",
-					"last":  "user",
-				},
-			},
-			After: map[string]any{
-				"name": map[string]any{
-					"first": "test",
-					"last":  "updated",
-				},
-			},
-			ExpectedDiffParagraph: "- name.last: user\n+ name.last: updated",
-		},
-	}
-
-	for _, test := range tests {
-		t.Run(test.Name, func(t *testing.T) {
-			diff := RenderItemDiff(test.Before, test.After)
-
-			if diff != test.ExpectedDiffParagraph {
-				t.Errorf("expected diff paragraph to be '%s', got '%s'", test.ExpectedDiffParagraph, diff)
-			}
-		})
-	}
-
-}
-
 func TestGcpSANameFromAccountName(t *testing.T) {
 	t.Parallel()