Skip to content

Commit 2b1321e

Browse files
Anton Vorontsovgregkh
authored andcommitted
staging: android: persistent_ram: Introduce persistent_ram_vmap()
Factor out vmap logic out of persistent_ram_buffer_map(), this will make the code a bit more understandable when we'll add support for non-bootmem memory. Signed-off-by: Anton Vorontsov <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 8cf5aff commit 2b1321e

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

drivers/staging/android/persistent_ram.c

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -318,14 +318,14 @@ void persistent_ram_free_old(struct persistent_ram_zone *prz)
318318
prz->old_log_size = 0;
319319
}
320320

321-
static int persistent_ram_buffer_map(phys_addr_t start, phys_addr_t size,
322-
struct persistent_ram_zone *prz)
321+
static void *persistent_ram_vmap(phys_addr_t start, size_t size)
323322
{
324323
struct page **pages;
325324
phys_addr_t page_start;
326325
unsigned int page_count;
327326
pgprot_t prot;
328327
unsigned int i;
328+
void *vaddr;
329329

330330
page_start = start - offset_in_page(start);
331331
page_count = DIV_ROUND_UP(size + offset_in_page(start), PAGE_SIZE);
@@ -336,17 +336,26 @@ static int persistent_ram_buffer_map(phys_addr_t start, phys_addr_t size,
336336
if (!pages) {
337337
pr_err("%s: Failed to allocate array for %u pages\n", __func__,
338338
page_count);
339-
return -ENOMEM;
339+
return NULL;
340340
}
341341

342342
for (i = 0; i < page_count; i++) {
343343
phys_addr_t addr = page_start + i * PAGE_SIZE;
344344
pages[i] = pfn_to_page(addr >> PAGE_SHIFT);
345345
}
346-
prz->vaddr = vmap(pages, page_count, VM_MAP, prot);
346+
vaddr = vmap(pages, page_count, VM_MAP, prot);
347347
kfree(pages);
348+
349+
return vaddr;
350+
}
351+
352+
static int persistent_ram_buffer_map(phys_addr_t start, phys_addr_t size,
353+
struct persistent_ram_zone *prz)
354+
{
355+
prz->vaddr = persistent_ram_vmap(start, size);
348356
if (!prz->vaddr) {
349-
pr_err("%s: Failed to map %u pages\n", __func__, page_count);
357+
pr_err("%s: Failed to map 0x%llx pages at 0x%llx\n", __func__,
358+
(unsigned long long)size, (unsigned long long)start);
350359
return -ENOMEM;
351360
}
352361

0 commit comments

Comments
 (0)