remove mutators

Signed-off-by: Per Goncalves da Silva <[email protected]>

Author: Per Goncalves da Silva

internal/operator-controller/rukpak/convert/generate.go renamed to internal/operator-controller/rukpak/convert/generators.go

@@ -45,12 +45,6 @@ func ChainedResourceGenerator(resourceGenerators ...ResourceGenerator) ResourceG
 	}
 }
 
-var BundleRBACResourceGenerator = ChainedResourceGenerator(
-	BundleServiceAccountGenerator,
-	BundlePermissionsGenerator,
-	BundleClusterPermissionsGenerator,
-)
-
 func BundleDeploymentGenerator(rv1 *RegistryV1, opts Options) ([]client.Object, error) {
 	if rv1 == nil {
 		return nil, fmt.Errorf("bundle cannot be nil")

internal/operator-controller/rukpak/convert/generate_test.go renamed to internal/operator-controller/rukpak/convert/generators_test.go

@@ -220,7 +220,9 @@ var PlainConverter = Converter{
 	BundleRenderer: BundleRenderer{
 		BundleValidator: RegistryV1BundleValidator,
 		ResourceGenerators: []ResourceGenerator{
-			BundleRBACResourceGenerator,
+			BundleServiceAccountGenerator,
+			BundlePermissionsGenerator,
+			BundleClusterPermissionsGenerator,
 			BundleCRDGenerator,
 			BundleAdditionalResourcesGenerator,
 			BundleDeploymentGenerator,

internal/operator-controller/rukpak/convert/mutate.go

@@ -2,7 +2,6 @@ package convert
 
 import (
 	"fmt"
-	"slices"
 
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
@@ -25,9 +24,8 @@ func (o *options) apply(opts ...Option) *options {
 }
 
 type BundleRenderer struct {
-	BundleValidator          BundleValidator
-	ResourceGenerators       []ResourceGenerator
-	ResourceMutatorFactories []ResourceMutatorFactory
+	BundleValidator    BundleValidator
+	ResourceGenerators []ResourceGenerator
 }
 
 func (r BundleRenderer) Render(rv1 RegistryV1, installNamespace string, watchNamespaces []string, opts ...Option) ([]client.Object, error) {
@@ -47,23 +45,12 @@ func (r BundleRenderer) Render(rv1 RegistryV1, installNamespace string, watchNam
 		UniqueNameGenerator: renderOptions.UniqueNameGenerator,
 	}
 
-	// generate object mutators
-	objMutators, err := ChainedResourceMutatorFactory(r.ResourceMutatorFactories).MakeResourceMutators(&rv1, genOpts)
-	if err != nil {
-		return nil, err
-	}
-
 	// generate bundle objects
 	objs, err := ChainedResourceGenerator(r.ResourceGenerators...).GenerateResources(&rv1, genOpts)
 	if err != nil {
 		return nil, err
 	}
 
-	// mutate objects
-	if err := objMutators.MutateObjects(slices.Values(objs)); err != nil {
-		return nil, err
-	}
-
 	return objs, nil
 }