refactor: move default value to new annotation and use it

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfiguration.java

@@ -8,6 +8,7 @@
 import io.fabric8.kubernetes.api.model.HasMetadata;
 import io.javaoperatorsdk.operator.ReconcilerUtils;
 import io.javaoperatorsdk.operator.api.config.dependent.DependentResourceSpec;
+import io.javaoperatorsdk.operator.api.reconciler.MaxReconciliationInterval;
 import io.javaoperatorsdk.operator.processing.event.rate.LinearRateLimiter;
 import io.javaoperatorsdk.operator.processing.event.rate.RateLimiter;
 import io.javaoperatorsdk.operator.processing.event.source.controller.ResourceEventFilter;
@@ -53,6 +54,7 @@ default RetryConfiguration getRetryConfiguration() {
     return RetryConfiguration.DEFAULT;
   }
 
+  @SuppressWarnings("rawtypes")
   default RateLimiter getRateLimiter() {
     return DEFAULT_RATE_LIMITER;
   }
@@ -78,7 +80,7 @@ default List<DependentResourceSpec> getDependentResources() {
   }
 
   default Optional<Duration> maxReconciliationInterval() {
-    return Optional.of(Duration.ofHours(10L));
+    return Optional.of(Duration.ofHours(MaxReconciliationInterval.DEFAULT_INTERVAL));
   }
 
   /**
@@ -87,7 +89,7 @@ default Optional<Duration> maxReconciliationInterval() {
    */
   @Deprecated(forRemoval = true)
   default Optional<Duration> reconciliationMaxInterval() {
-    return Optional.of(Duration.ofHours(10L));
+    return Optional.of(Duration.ofHours(MaxReconciliationInterval.DEFAULT_INTERVAL));
   }
 
   @SuppressWarnings("unused")

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ControllerConfiguration.java

@@ -96,7 +96,7 @@
    */
   @Deprecated(forRemoval = true)
   ReconciliationMaxInterval reconciliationMaxInterval() default @ReconciliationMaxInterval(
-      interval = ReconciliationMaxInterval.DEFAULT_INTERVAL);
+      interval = MaxReconciliationInterval.DEFAULT_INTERVAL);
 
   /**
    * Optional configuration of the maximal interval the SDK will wait for a reconciliation request
@@ -105,7 +105,7 @@ ReconciliationMaxInterval reconciliationMaxInterval() default @ReconciliationMax
    * @return the maximal reconciliation interval configuration
    */
   MaxReconciliationInterval maxReconciliationInterval() default @MaxReconciliationInterval(
-      interval = 10);
+      interval = MaxReconciliationInterval.DEFAULT_INTERVAL);
 
 
   /**

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/MaxReconciliationInterval.java

@@ -10,6 +10,8 @@
 @Target({ElementType.TYPE})
 public @interface MaxReconciliationInterval {
 
+  long DEFAULT_INTERVAL = 10;
+
   /**
    * A max delay between two reconciliations. Having this value larger than zero, will ensure that a
    * reconciliation is scheduled with a target interval after the last reconciliation. Note that

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/ReconciliationMaxInterval.java

@@ -13,8 +13,6 @@
 @Target({ElementType.TYPE})
 @Deprecated(forRemoval = true)
 public @interface ReconciliationMaxInterval {
-  long DEFAULT_INTERVAL = 10;
-
   /**
    * A max delay between two reconciliations. Having this value larger than zero, will ensure that a
    * reconciliation is scheduled with a target interval after the last reconciliation. Note that