Don't remove null type if default is present (legacy)

Author: luhn

packages/openapi-typescript/examples/digital-ocean-api.ts

@@ -12326,7 +12326,7 @@ export interface components {
              *       "web"
              *     ]
              */
-            tags: string[];
+            tags: string[] | null;
             /**
              * @description A string containing 'user data' which may be used to configure the Droplet on first boot, often a 'cloud-config' file or Bash script. It must be plain text and may not exceed 64 KiB in size.
              * @example #cloud-config

packages/openapi-typescript/examples/github-api-export-type-immutable.ts

@@ -108426,7 +108426,7 @@ export interface operations {
                 /** @description The name of the task for the deployment (e.g., `deploy` or `deploy:migrations`). */
                 readonly task?: string;
                 /** @description The name of the environment that was deployed to (e.g., `staging` or `production`). */
-                readonly environment?: string;
+                readonly environment?: string | null;
                 /** @description The number of results per page (max 100). For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */
                 readonly per_page?: components["parameters"]["per-page"];
                 /** @description The page number of the results to fetch. For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */

packages/openapi-typescript/examples/github-api-immutable.ts

@@ -108426,7 +108426,7 @@ export interface operations {
                 /** @description The name of the task for the deployment (e.g., `deploy` or `deploy:migrations`). */
                 readonly task?: string;
                 /** @description The name of the environment that was deployed to (e.g., `staging` or `production`). */
-                readonly environment?: string;
+                readonly environment?: string | null;
                 /** @description The number of results per page (max 100). For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */
                 readonly per_page?: components["parameters"]["per-page"];
                 /** @description The page number of the results to fetch. For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */

packages/openapi-typescript/examples/github-api-required.ts

@@ -108426,7 +108426,7 @@ export interface operations {
                 /** @description The name of the task for the deployment (e.g., `deploy` or `deploy:migrations`). */
                 task?: string;
                 /** @description The name of the environment that was deployed to (e.g., `staging` or `production`). */
-                environment?: string;
+                environment?: string | null;
                 /** @description The number of results per page (max 100). For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */
                 per_page?: components["parameters"]["per-page"];
                 /** @description The page number of the results to fetch. For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */

packages/openapi-typescript/examples/github-api-root-types.ts

@@ -109453,7 +109453,7 @@ export interface operations {
                 /** @description The name of the task for the deployment (e.g., `deploy` or `deploy:migrations`). */
                 task?: string;
                 /** @description The name of the environment that was deployed to (e.g., `staging` or `production`). */
-                environment?: string;
+                environment?: string | null;
                 /** @description The number of results per page (max 100). For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */
                 per_page?: components["parameters"]["per-page"];
                 /** @description The page number of the results to fetch. For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */

packages/openapi-typescript/examples/github-api.ts

@@ -108426,7 +108426,7 @@ export interface operations {
                 /** @description The name of the task for the deployment (e.g., `deploy` or `deploy:migrations`). */
                 task?: string;
                 /** @description The name of the environment that was deployed to (e.g., `staging` or `production`). */
-                environment?: string;
+                environment?: string | null;
                 /** @description The number of results per page (max 100). For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */
                 per_page?: components["parameters"]["per-page"];
                 /** @description The page number of the results to fetch. For more information, see "[Using pagination in the REST API](https://docs.github.com/rest/using-the-rest-api/using-pagination-in-the-rest-api)." */

packages/openapi-typescript/src/transform/schema-object.ts

@@ -263,7 +263,7 @@ export function transformSchemaObjectWithComposition(
     }
   }
 
-  if (finalType !== UNKNOWN && schemaObject.nullable && !schemaObject.default) {
+  if (finalType !== UNKNOWN && schemaObject.nullable) {
     finalType = tsNullable([finalType]);
   }
 

packages/openapi-typescript/test/transform/schema-object/string.test.ts

@@ -116,7 +116,7 @@ describe("transformSchemaObject > string", () => {
       "default + nullable (deprecated syntax)",
       {
         given: { type: "string", default: "en", nullable: true },
-        want: "string",
+        want: "string | null",
       },
     ],
   ];