Skip to content

Commit 186ea98

Browse files
committed
Adds more comments
1 parent eade875 commit 186ea98

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

model/trace/instrumentation/graphql.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ groups:
3030
type: string
3131
note: The value may be sanitized to exclude sensitive information.
3232
examples: "query findBookById { bookById(id: ?) { name } }"
33+
- id: document.sha256
34+
brief: "The SHA256 hash of the document.content"
35+
type: string
36+
examples: "400483f38c08e8a3d3b972409c9dfb8e4a326e1b1940864932acd9f873d8664c"
3337
- id: document.id
3438
brief: >
3539
The id of the document beeing executed. This is a hash of the document provided by the user to identitfy
@@ -41,7 +45,9 @@ groups:
4145
type: int
4246
examples: 3
4347
# TODO should we have something like outcome (success, failure)
48+
# TODO how do we specify errors?
4449
# TODO Should we ref network.transport, network.type, server.address etc?
50+
# TODO There are more spans like validation, parsing, variable coercion and response formatting. Should we add them as separate span types?
4551

4652
- id: graphql.server.resolver
4753
prefix: graphql

0 commit comments

Comments
 (0)