Skip to content

Commit 0755a5c

Browse files
authored
fix(ci): don't collect coverage for eol tests (#4030)
1 parent c021b10 commit 0755a5c

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

.github/workflows/unit-test.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,4 +201,9 @@ jobs:
201201
202202
- name: Test
203203
working-directory: ./api
204-
run: npm test
204+
# running test:eol as node 8 is not supported anymore by the version of nyc we use, as we don't report coverage
205+
# for this step we leave it out.
206+
# Details: nyc requires istanbul-lib-report, which silently dropped support for Node.js v8 when going from
207+
# 3.0.0 to 3.0.1 by requiring make-dir@^4.0.0 to fix https://github.com/advisories/GHSA-c2qf-rxjj-qqgw.
208+
# make-dir does not support Node.js v8 anymore.
209+
run: npm run test:eol

api/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"lint": "eslint . --ext .ts",
2626
"test:browser": "karma start --single-run",
2727
"test": "nyc ts-mocha -p tsconfig.json 'test/**/*.test.ts'",
28+
"test:eol": "ts-mocha -p tsconfig.json 'test/**/*.test.ts'",
2829
"test:webworker": "karma start karma.worker.js --single-run",
2930
"cycle-check": "dpdm --exit-code circular:1 src/index.ts",
3031
"version": "node ../scripts/version-update.js",

0 commit comments

Comments
 (0)