Skip to content

Commit b40d6c4

Browse files
committed
fix tests
1 parent c73a7ec commit b40d6c4

File tree

3 files changed

+10
-60
lines changed

3 files changed

+10
-60
lines changed

messaging-wrappers/README.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22

33
This is a lightweight messaging wrappers API designed to help you quickly add instrumentation to any
44
type of messaging system client. To further ease the burden of instrumentation, we will also provide
5-
predefined implementations for certain messaging systems, helping you seamlessly address the issue
5+
predefined implementations for certain messaging systems, helping you seamlessly address the issue
66
of broken traces.
77

88
## Overview
99

10-
The primary goal of this API is to simplify the process of adding instrumentation to your messaging
11-
systems, thereby enhancing observability without introducing significant overhead. Inspired by
12-
[#13340](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/13340) and
13-
[opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractor.java),
10+
The primary goal of this API is to simplify the process of adding instrumentation to your messaging
11+
systems, thereby enhancing observability without introducing significant overhead. Inspired by
12+
[#13340](https://github.com/open-telemetry/opentelemetry-java-instrumentation/issues/13340) and
13+
[opentelemetry-java-instrumentation](https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingAttributesExtractor.java),
1414
this tool aims to streamline the tracing and monitoring process.
1515

1616
## Predefined Implementations
@@ -31,7 +31,7 @@ Gradle and Maven.
3131

3232
```kotlin
3333
dependencies {
34-
implementation("io.opentelemetry.contrib:opentelemetry-messaging-wrappers-api")
34+
implementation("io.opentelemetry.contrib:opentelemetry-messaging-wrappers-api:${latest_version}")
3535
}
3636
```
3737

@@ -41,6 +41,7 @@ dependencies {
4141
<dependency>
4242
<groupId>io.opentelemetry.contrib</groupId>
4343
<artifactId>opentelemetry-messaging-wrappers-api</artifactId>
44+
<version>${latest_version}</version>
4445
</dependency>
4546
```
4647

@@ -81,7 +82,7 @@ an implementation based on the OpenTelemetry semantic convention by default.
8182

8283
```java
8384
public class KafkaDemo {
84-
85+
8586
public static MessagingProcessWrapper<KafkaProcessRequest> createWrapper() {
8687
return KafkaHelper.processWrapperBuilder().build();
8788
}
@@ -98,9 +99,9 @@ If both are enabled, it might result in duplicate nested process spans. It is re
9899

99100
```java
100101
public class Demo {
101-
102+
102103
private static final MessagingProcessWrapper<MyMessagingProcessRequest> WRAPPER = createWrapper();
103-
104+
104105
public String consume(Message message) {
105106
WRAPPER.doProcess(new MyMessagingProcessRequest(message), () -> {
106107
// your processing logic

messaging-wrappers/aliyun-mns-sdk/src/main/java/io/opentelemetry/contrib/messaging/wrappers/mns/MnsHelper.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.aliyun.mns.model.MessageSystemPropertyName;
1111
import com.aliyun.mns.model.MessageSystemPropertyValue;
1212
import io.opentelemetry.contrib.messaging.wrappers.mns.semconv.MnsProcessRequest;
13-
1413
import javax.annotation.Nullable;
1514

1615
public final class MnsHelper {

messaging-wrappers/kafka-clients/src/test/java/io/opentelemetry/contrib/messaging/wrappers/kafka/internal/AutoConfiguredDataCapture.java

Lines changed: 0 additions & 50 deletions
This file was deleted.

0 commit comments

Comments
 (0)