Bind stdouttrace self-observability inst

Author: MrAlias

exporters/stdout/stdouttrace/go.mod

@@ -8,6 +8,7 @@ replace (
 )
 
 require (
+	github.com/MrAlias/bind v0.1.1
 	github.com/stretchr/testify v1.11.0
 	go.opentelemetry.io/otel v1.37.0
 	go.opentelemetry.io/otel/metric v1.37.0

exporters/stdout/stdouttrace/go.sum

@@ -1,3 +1,5 @@
+github.com/MrAlias/bind v0.1.1 h1:y7FRVkD4HK3ut0eJ768ZQsqBUUgD7+/oEwVYjrULgO8=
+github.com/MrAlias/bind v0.1.1/go.mod h1:5B4HdQ8kUm9kZ4pVdE7a/HJAPzPz6CWKh7Hd40CYWZw=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=

exporters/stdout/stdouttrace/trace.go

@@ -11,6 +11,8 @@ import (
 	"sync"
 	"time"
 
+	"github.com/MrAlias/bind"
+
 	"go.opentelemetry.io/otel"
 	"go.opentelemetry.io/otel/attribute"
 	"go.opentelemetry.io/otel/exporters/stdout/stdouttrace/internal/counter"
@@ -51,12 +53,10 @@ func New(options ...Option) (*Exporter, error) {
 	}
 
 	exporter.selfObservabilityEnabled = true
-	exporter.selfObservabilityAttrs = []attribute.KeyValue{
-		semconv.OTelComponentName(fmt.Sprintf("%s/%d", otelComponentType, counter.NextExporterID())),
-		semconv.OTelComponentTypeKey.String(otelComponentType),
-	}
-	s := attribute.NewSet(exporter.selfObservabilityAttrs...)
-	exporter.selfObservabilitySetOpt = metric.WithAttributeSet(s)
+
+	name := fmt.Sprintf("%s/%d", otelComponentType, counter.NextExporterID())
+	cmpnt := semconv.OTelComponentName(name)
+	cmpntT := semconv.OTelComponentTypeKey.String(otelComponentType)
 
 	mp := otel.GetMeterProvider()
 	m := mp.Meter(
@@ -65,18 +65,35 @@ func New(options ...Option) (*Exporter, error) {
 		metric.WithSchemaURL(semconv.SchemaURL),
 	)
 
-	var err, e error
-	if exporter.spanInflightMetric, e = otelconv.NewSDKExporterSpanInflight(m); e != nil {
+	var err error
+	if i, e := otelconv.NewSDKExporterSpanInflight(m); e != nil {
 		e = fmt.Errorf("failed to create span inflight metric: %w", e)
 		err = errors.Join(err, e)
+	} else {
+		bound := bind.Int64UpDownCounter(i.Inst(), cmpnt, cmpntT)
+		exporter.spanInflightMetric = otelconv.SDKExporterSpanInflight{
+			Int64UpDownCounter: bound,
+		}
 	}
-	if exporter.spanExportedMetric, e = otelconv.NewSDKExporterSpanExported(m); e != nil {
+
+	if i, e := otelconv.NewSDKExporterSpanExported(m); e != nil {
 		e = fmt.Errorf("failed to create span exported metric: %w", e)
 		err = errors.Join(err, e)
+	} else {
+		bound := bind.Int64Counter(i.Inst(), cmpnt, cmpntT)
+		exporter.spanExportedMetric = otelconv.SDKExporterSpanExported{
+			Int64Counter: bound,
+		}
 	}
-	if exporter.operationDurationMetric, e = otelconv.NewSDKExporterOperationDuration(m); e != nil {
+
+	if i, e := otelconv.NewSDKExporterOperationDuration(m); e != nil {
 		e = fmt.Errorf("failed to create operation duration metric: %w", e)
 		err = errors.Join(err, e)
+	} else {
+		bound := bind.Float64Histogram(i.Inst(), cmpnt, cmpntT)
+		exporter.operationDurationMetric = otelconv.SDKExporterOperationDuration{
+			Float64Histogram: bound,
+		}
 	}
 
 	return exporter, err
@@ -92,67 +109,39 @@ type Exporter struct {
 	stopped   bool
 
 	selfObservabilityEnabled bool
-	selfObservabilityAttrs   []attribute.KeyValue // selfObservability common attributes
-	selfObservabilitySetOpt  metric.MeasurementOption
 	spanInflightMetric       otelconv.SDKExporterSpanInflight
 	spanExportedMetric       otelconv.SDKExporterSpanExported
 	operationDurationMetric  otelconv.SDKExporterOperationDuration
 }
 
-var (
-	measureAttrsPool = sync.Pool{
-		New: func() any {
-			// "component.name" + "component.type" + "error.type"
-			const n = 1 + 1 + 1
-			s := make([]attribute.KeyValue, 0, n)
-			// Return a pointer to a slice instead of a slice itself
-			// to avoid allocations on every call.
-			return &s
-		},
-	}
-
-	addOptPool = &sync.Pool{
-		New: func() any {
-			const n = 1 // WithAttributeSet
-			o := make([]metric.AddOption, 0, n)
-			return &o
-		},
-	}
-
-	recordOptPool = &sync.Pool{
-		New: func() any {
-			const n = 1 // WithAttributeSet
-			o := make([]metric.RecordOption, 0, n)
-			return &o
-		},
-	}
-)
+var measureAttrsPool = sync.Pool{
+	New: func() any {
+		// "error.type"
+		const n = 1
+		s := make([]attribute.KeyValue, 0, n)
+		// Return a pointer to a slice instead of a slice itself
+		// to avoid allocations on every call.
+		return &s
+	},
+}
 
 // ExportSpans writes spans in json format to stdout.
 func (e *Exporter) ExportSpans(ctx context.Context, spans []trace.ReadOnlySpan) (err error) {
 	var success int64
 	if e.selfObservabilityEnabled {
 		count := int64(len(spans))
 
-		addOpt := addOptPool.Get().(*[]metric.AddOption)
-		defer func() {
-			*addOpt = (*addOpt)[:0]
-			addOptPool.Put(addOpt)
-		}()
-
-		*addOpt = append(*addOpt, e.selfObservabilitySetOpt)
-
-		e.spanInflightMetric.Inst().Add(ctx, count, *addOpt...)
+		e.spanInflightMetric.Add(ctx, count)
 		defer func(starting time.Time) {
-			e.spanInflightMetric.Inst().Add(ctx, -count, *addOpt...)
+			e.spanInflightMetric.Add(ctx, -count)
 
 			// Record the success and duration of the operation.
 			//
 			// Do not exclude 0 values, as they are valid and indicate no spans
 			// were exported which is meaningful for certain aggregations.
-			e.spanExportedMetric.Inst().Add(ctx, success, *addOpt...)
+			e.spanExportedMetric.Add(ctx, success)
 
-			mOpt := e.selfObservabilitySetOpt
+			set := *attribute.EmptySet()
 			if err != nil {
 				// additional attributes for self-observability,
 				// only spanExportedMetric and operationDurationMetric are supported.
@@ -161,36 +150,13 @@ func (e *Exporter) ExportSpans(ctx context.Context, spans []trace.ReadOnlySpan)
 					*attrs = (*attrs)[:0] // reset the slice for reuse
 					measureAttrsPool.Put(attrs)
 				}()
-				*attrs = append(*attrs, e.selfObservabilityAttrs...)
 				*attrs = append(*attrs, semconv.ErrorType(err))
+				set = attribute.NewSet(*attrs...)
 
-				// Do not inefficiently make a copy of attrs by using
-				// WithAttributes instead of WithAttributeSet.
-				set := attribute.NewSet(*attrs...)
-				mOpt = metric.WithAttributeSet(set)
-
-				// Reset addOpt with new attribute set.
-				*addOpt = append((*addOpt)[:0], mOpt)
-
-				e.spanExportedMetric.Inst().Add(
-					ctx,
-					count-success,
-					*addOpt...,
-				)
+				e.spanExportedMetric.AddSet(ctx, count-success, set)
 			}
 
-			recordOpt := recordOptPool.Get().(*[]metric.RecordOption)
-			defer func() {
-				*recordOpt = (*recordOpt)[:0]
-				recordOptPool.Put(recordOpt)
-			}()
-
-			*recordOpt = append(*recordOpt, mOpt)
-			e.operationDurationMetric.Inst().Record(
-				ctx,
-				time.Since(starting).Seconds(),
-				*recordOpt...,
-			)
+			e.operationDurationMetric.RecordSet(ctx, time.Since(starting).Seconds(), set)
 		}(time.Now())
 	}