Skip to content

Commit 94c20c6

Browse files
Remove userAgent tag from HttpClient activity (#5110)
1 parent 61c6c74 commit 94c20c6

File tree

2 files changed

+3
-9
lines changed

2 files changed

+3
-9
lines changed

src/OpenTelemetry.Instrumentation.Http/CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,9 @@
2323
`HttpClientTraceInstrumentationOptions`.
2424
([#5109](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5109))
2525

26+
* **Breaking Change**: Removed `http.user_agent` tag from HttpClient activity.
27+
([#5110](https://github.com/open-telemetry/opentelemetry-dotnet/pull/5110))
28+
2629
## 1.6.0-beta.3
2730

2831
Released 2023-Nov-17

src/OpenTelemetry.Instrumentation.Http/Implementation/HttpHandlerDiagnosticListener.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -167,15 +167,6 @@ public void OnStartActivity(Activity activity, object payload)
167167

168168
activity.SetTag(SemanticConventions.AttributeUrlFull, HttpTagHelper.GetUriTagValueFromRequestUri(request.RequestUri));
169169

170-
if (request.Headers.TryGetValues("User-Agent", out var userAgentValues))
171-
{
172-
var userAgent = userAgentValues.FirstOrDefault();
173-
if (!string.IsNullOrEmpty(userAgent))
174-
{
175-
activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent);
176-
}
177-
}
178-
179170
try
180171
{
181172
this.options.EnrichWithHttpRequestMessage?.Invoke(activity, request);

0 commit comments

Comments
 (0)