Skip to content

Commit 30e7528

Browse files
xuhdevbaylesj
andauthored
Return false in Reader::readValue when stack limit is exceeded (#1619)
jsoncpp, as a shared library, should not call `abort` merely because there's an error reading a value. See https://en.cppreference.com/w/c/program/abort, `abort` should only be called to **abnormally** cause the program to exit. Functions inserted by `atexit` are also not called, meaning that the host program may have not cleaned up resources properly. But here, exceeding stack limit isn't a sign of abnormalty. `exit` is not a good substitute either, see the `exit-in-shared-library` from Debian: https://lintian.debian.org/tags/exit-in-shared-library.html Fix #1618 In this case, returning false seems like a better idea. Co-authored-by: Jordan Bayles <[email protected]>
1 parent 4bcbc6a commit 30e7528

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/lib_json/json_reader.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,12 @@ bool Reader::readValue() {
144144
// after calling readValue(). parse() executes one nodes_.push(), so > instead
145145
// of >=.
146146
if (nodes_.size() > stackLimit_g)
147+
#if JSON_USE_EXCEPTION
147148
throwRuntimeError("Exceeded stackLimit in readValue().");
149+
#else
150+
// throwRuntimeError aborts. Don't abort here.
151+
return false;
152+
#endif
148153

149154
Token token;
150155
readTokenSkippingComments(token);

0 commit comments

Comments
 (0)