fix: remove incorrect undici dep #1319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* this dep was automatically added by our dep detection due to it including jest.polyfill.js * its only needed for testing, so Ive removed it and added an exception to our dep linting Signed-off-by: Todd Baert <[email protected]>
toddbaert
commented
Jun 23, 2025
| "checkVersionMismatches": true, | ||
| "ignoredDependencies": ["jest-cucumber", "jest"], | ||
| "ignoredFiles": ["**/test/**", "**/tests/*", "**/spec/**", "**/*.spec.ts", "**/*.spec.js", "**/*.test.ts", "**/*.test.js"] | ||
| "ignoredFiles": ["**/test/**", "**/tests/*", "**/spec/**", "**/*.spec.ts", "**/*.spec.js", "**/*.test.ts", "**/*.test.js", "**/jest.*"] |
Member
Author
There was a problem hiding this comment.
jest.polyfills.js was not excluded, and resides in non /test folders so imports in it were detected as a "real" dependency usage.
aepfli
approved these changes
Jun 23, 2025
This was referenced Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jest.polyfill.js