some cleaning based on cppcheck

Author: okbob

src/inputs.c

@@ -354,7 +354,7 @@ get_ncurses_event(NCursesEventData *nced, bool *sigint, bool *sigwinch)
  * content - new data, inotify event, .. These events are saved, but for this moment ignored.
  * Timeout -1 (timeout is infinity), 0 (no any wait), else timeout in ms.
  */
-int
+static int
 _get_pspg_event(NCursesEventData *nced,
 			    bool only_tty_events,
 			    int timeout)

src/pspg.c

@@ -251,7 +251,7 @@ SigtermHandler(int sig_num)
 }
 
 /* Custom SIGSEGV handler. */
-void
+static void
 SigsegvHandler (int sig)
 {
 	exit_handler();
@@ -299,7 +299,7 @@ max_int(int a, int b)
  * The argument "b" should be >= "a" or it should be ignored
  * and "a" is used instead "b".
  */
-int
+static int
 trim_to_range(int v, int a, int b)
 {
 	/*
@@ -2157,8 +2157,6 @@ export_to_file(PspgCommand command,
 				snprintf(cmdline_clipboard_app, 1024, "wl-copy -t %s", fmt);
 			else if (clipboard_application_id == 2)
 				snprintf(cmdline_clipboard_app, 1024, "xclip -sel clip");
-			else if (clipboard_application_id == 4)
-				snprintf(cmdline_clipboard_app, 1024, "clip.exe");
 
 			if ((pid = rwe_popen(cmdline_clipboard_app, &fin, &fout, &ferr)) == -1)
 			{
@@ -4496,7 +4494,7 @@ main(int argc, char *argv[])
 													   vertical_cursor_column))
 						break;
 
-					if (mark_mode != MARK_MODE_BLOCK || mark_mode != MARK_MODE_COLUMNS)
+					if (mark_mode != MARK_MODE_BLOCK && mark_mode != MARK_MODE_COLUMNS)
 					{
 						throw_selection(&scrdesc, &desc, &mark_mode);
 

src/table.c

@@ -839,7 +839,7 @@ readfile(Options *opts, DataDesc *desc, StateData *state)
 			char   *newline, *writeptr, *readptr;
 			int		total_dl = 0;
 
-			while ((tabptr = memchr(tabptr + 1, '\t', endptr - tabptr)))
+			while ((tabptr = memchr(((char *) tabptr) + 1, '\t', endptr - tabptr)))
 			{
 				tabcount += 1;
 			}

src/themes.c

@@ -258,15 +258,15 @@ color_index_rgb(unsigned int rgb)
 
 #define RGB(r, g, b)		((((int)(r / 1000.0 * 255.0)) << 16) + (((int)(g / 1000.0 * 255.0)) << 8) + ((int)(b / 1000.0 * 255.0)))
 
-void
+static void
 deftheme(PspgThemeElements idx, PspgColor fg, PspgColor bg, int attr)
 {
 	memcpy(&themedef[idx][current_themedef_bank].fg, &fg, sizeof(PspgColor));
 	memcpy(&themedef[idx][current_themedef_bank].bg, &bg, sizeof(PspgColor));
 	themedef[idx][current_themedef_bank].attr = attr;
 }
 
-void
+static void
 deftheme_rgb(PspgThemeElements idx, unsigned int fg, unsigned int bg, int attr)
 {
 	PspgThemeElement *te = &themedef[idx][current_themedef_bank];