fix(Runtime): Deformation constraint sets up data at edit time

Summary:
Deformation logic's data must be set up at edit time. This prevents it from having to set itself up before the skeleton initializes at runtime, which can be error-prone due to race conditions.

This diff updates the retargeted robot and High Fi characters because they use deformation logic.

Reviewed By: andkim-meta

Differential Revision: D47276990

fbshipit-source-id: 7247ce79c5c56c7d48a46fd05bf99e38fd2626de

Author: sohailshafiiWk

Editor/AnimationRigging/DeformationConstraintEditor.cs

@@ -16,6 +16,7 @@ public override void OnInspectorGUI()
         {
             var constraint = (DeformationConstraint)target;
             IDeformationData constraintData = constraint.data;
+
             if (constraintData.ConstraintCustomSkeleton == null &&
                 constraintData.ConstraintAnimator == null)
             {
@@ -24,15 +25,71 @@ public override void OnInspectorGUI()
                     Undo.RecordObject(constraint, "Find OVR Custom Skeleton");
                     var skeleton = constraint.GetComponentInParent<OVRCustomSkeleton>();
                     constraint.data.AssignOVRCustomSkeleton(skeleton);
+                    EditorUtility.SetDirty(target);
                 }
                 if (GUILayout.Button("Find Animator"))
                 {
                     Undo.RecordObject(constraint, "Find Animator");
                     var animator = constraint.GetComponentInParent<Animator>();
                     constraint.data.AssignAnimator(animator);
+                    EditorUtility.SetDirty(target);
+                }
+            }
+            if (constraintData.HipsToHeadBones == null ||
+                constraintData.HipsToHeadBones.Length == 0)
+            {
+                if (GUILayout.Button("Find Hips To Head Bones"))
+                {
+                    Undo.RecordObject(constraint, "Find Hips To Head Bones");
+                    constraint.data.SetUpHipsAndHeadBones();
+                    EditorUtility.SetDirty(target);
+                }
+            }
+            if (!constraintData.LeftArmDataInitialized)
+            {
+                if (GUILayout.Button("Initialize Left Arm"))
+                {
+                    Undo.RecordObject(constraint, "Initialize Left Arm");
+                    constraint.data.SetUpLeftArmData();
+                    EditorUtility.SetDirty(target);
+                }
+            }
+            if (!constraintData.RightArmDataInitialized)
+            {
+                if (GUILayout.Button("Initialize Right Arm"))
+                {
+                    Undo.RecordObject(constraint, "Initialize Right Arm");
+                    constraint.data.SetUpRightArmData();
+                    EditorUtility.SetDirty(target);
                 }
-                GUILayout.Space(EditorGUIUtility.standardVerticalSpacing);
             }
+            if (constraintData.BonePairs == null ||
+                constraintData.BonePairs.Length == 0)
+            {
+                if (GUILayout.Button("Initialize Bone Pairs"))
+                {
+                    Undo.RecordObject(constraint, "Initialize Bone Pairs");
+                    constraint.data.SetUpBonePairs();
+                    EditorUtility.SetDirty(target);
+                }
+            }
+
+            if (GUILayout.Button("Initialize starting scale"))
+            {
+                Undo.RecordObject(constraint, "Initialize starting scale");
+                constraint.data.InitializeStartingScale();
+                EditorUtility.SetDirty(target);
+            }
+
+            if (GUILayout.Button("Clear Transform data"))
+            {
+                Undo.RecordObject(constraint, "Clear Transform data");
+                constraint.data.ClearTransformData();
+                EditorUtility.SetDirty(target);
+            }
+
+            GUILayout.Space(EditorGUIUtility.standardVerticalSpacing);
+
             DrawDefaultInspector();
         }
     }

Editor/AnimationRigging/GroundingConstraintEditor.cs

@@ -43,7 +43,6 @@ public override void OnInspectorGUI()
                 }
             }
 
-
             if (GUILayout.Button("Compute Offsets"))
             {
                 Undo.RecordObject(constraint, "Compute Offsets");