Skip to content

[BUG]: Webhook installation type missing client_id #1003

@nathandao

Description

@nathandao

What happened?

Looks like all webhooks we received from GH now contains the Installation's client_id field, but it is not documented in the type. And I found a related announcement about replacing app_id by client_id as the unique identifier. Would it make sense to at least add an optional client_id field to the Installation type?

Versions

@octokit/webhooks-types v7.6.1

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type: BugSomething isn't working as documented

    Type

    No type

    Projects

    Status

    🏗 In progress

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions