Having trouble understanding how to return multi from mini_pick.builtin.files()

[theherk]

Contributing guidelines

• I have read CODE_OF_CONDUCT.md

Module(s)

mini.pick

Question

I added mini.pick to the file selectors for avante.nvim. However, it seems it was broken in this PR. I have fixed that by updating the code to:

function FileSelector:mini_pick_ui(handler)
  local success, mini_pick = pcall(require, "mini.pick")
  if not success then
    Utils.error("mini.pick is not installed. Please install mini.pick to use it as a file selector.")
    return
  end
  local result = mini_pick.builtin.files()
  vim.notify(vim.inspect(result)) -- Just for verification.
  if not result then
    handler(nil)
    return
  end
  handler(type(result) == "string" and { result } or result)
end

This works, and I believe it would work with multi select, but when I select multiple with <c-x> then use <m-cr>, the function only returns current, but the selections are opened in quickfix.

How can I actually return selected files?

[echasnovski]

The returned value of MiniPick.start() is indeed the item that was current when is stopped. For the common case of choosing an item with "choose" action (<CR> by default) it is indeed the chosen item, hence the design.

A more idiomatic approach to this would be to define custom source.choose and source.choose_marked and supply it to MiniPick.builtin.files directly. So something like this:

function FileSelector:mini_pick_ui(handler)
  if not _G.MiniPick then
    Utils.error('mini.pick is not set up. Please install and set up mini.pick to use it as a file selector.')
    return
  end

  local choose = function(item) handler(type(item) == 'string' and { item } or item) end
  local choose_marked = function(items_marked) handler(items_marked) end
  local source = { choose = choose, choose_marked = choose_marked }
  local result = MiniPick.builtin.files(nil, { source = source })
  if result == nil then handler(nil) end
end

[theherk]

Thank you so much. Clean and works like a charm.