async_wrap: fix memory leak in AsyncResource

mhdawson · MylesBorins · commit d7d5f11522e3 · 2018-07-09T16:33:05.000-04:00
Reset the persistent that keeps the resource Object alive when the AsyncResource is being destroyed. Fixes: nodejs/node-addon-api#237 PR-URL: #20668 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.h b/src/node.h
@@ -735,6 +735,7 @@ class AsyncResource {
 
     virtual ~AsyncResource() {
       EmitAsyncDestroy(isolate_, async_context_);
+      resource_.Reset();
     }
 
     v8::MaybeLocal<v8::Value> MakeCallback(

Original file line number	Diff line number	Diff line change
`@@ -735,6 +735,7 @@ class AsyncResource {`
`735`	`735`
`736`	`736`	`virtual ~AsyncResource() {`
`737`	`737`	`EmitAsyncDestroy(isolate_, async_context_);`
	`738`	`+ resource_.Reset();`
`738`	`739`	`}`
`739`	`740`
`740`	`741`	`v8::MaybeLocal<v8::Value> MakeCallback(`