@@ -24,8 +24,9 @@ understand the project governance model as outlined in
2424
2525## Issues and Pull Requests
2626
27- Courtesy should always be shown to individuals submitting issues and
28- pull requests to the Node.js project.
27+ Courtesy should ** always** be shown to individuals submitting issues and pull
28+ requests to the Node.js project. Be welcoming to first time contributors,
29+ identified by the GitHub ![ badge] ( ./doc/first_timer_badge.png ) badge.
2930
3031Collaborators should feel free to take full responsibility for
3132managing issues and pull requests they feel qualified to handle, as
@@ -68,6 +69,9 @@ wide-reaching impact), and focused changes that affect only documentation
6869and/or the test suite, may be landed after a shorter delay if they have
6970multiple approvals.
7071
72+ For first time contributors, ask the author if they have configured their git
73+ username and email to their liking as per [ this guide] [ git-username ] .
74+
7175For non-breaking changes, if there is no disagreement amongst
7276Collaborators, a pull request may be landed given appropriate review.
7377Where there is discussion amongst Collaborators, consensus should be
@@ -356,10 +360,8 @@ The TSC should serve as the final arbiter where required.
356360 * If you do, please force-push removing the merge.
357361 * Reasons for not using the web interface button:
358362 * The merge method will add an unnecessary merge commit.
359- * The rebase & merge method adds metadata to the commit title.
360- * The rebase method changes the author.
361363 * The squash & merge method has been known to add metadata to the
362- commit title.
364+ commit title (the PR #) .
363365 * If more than one author has contributed to the PR, keep the most recent
364366 author when squashing.
365367
@@ -669,3 +671,4 @@ LTS working group and the Release team.
669671[ backporting guide ] : doc/guides/backporting-to-release-lines.md
670672[ Stability Index ] : doc/api/documentation.md#stability-index
671673[ Enhancement Proposal ] : https://github.com/nodejs/node-eps
674+ [ git-username ] : https://help.github.com/articles/setting-your-username-in-git/
0 commit comments