Skip to content

Commit 81890a1

Browse files
author
Guy Bedford
committed
Revert "update to latest v8"
This reverts commit 009373d.
1 parent 009373d commit 81890a1

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

src/module_wrap.cc

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,8 +1019,10 @@ void ModuleWrap::SetImportModuleDynamicallyCallback(
10191019
realm->set_host_import_module_dynamically_callback(import_callback);
10201020

10211021
isolate->SetHostImportModuleDynamicallyCallback(ImportModuleDynamically);
1022-
isolate->SetHostImportModuleWithPhaseDynamicallyCallback(
1023-
ImportModuleDynamicallyWithPhase);
1022+
// TODO(guybedford): Enable this once
1023+
// https://github.com/nodejs/node/pull/56842 lands.
1024+
// isolate->SetHostImportModuleWithPhaseDynamicallyCallback(
1025+
// ImportModuleDynamicallyWithPhase);
10241026
}
10251027

10261028
void ModuleWrap::HostInitializeImportMetaObjectCallback(Local<Context> context,

test/es-module/test-esm-wasm.mjs

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
112112
strictEqual(code, 0);
113113
});
114114

115-
it('should support dynamic source phase imports', async () => {
115+
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
116+
it.skip('should support dynamic source phase imports', async () => {
116117
const { code, stderr, stdout } = await spawnPromisified(execPath, [
117118
'--no-warnings',
118119
'--experimental-wasm-modules',
@@ -152,7 +153,8 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
152153
strictEqual(code, 0);
153154
});
154155

155-
it('should not execute dynamic source phase imports', async () => {
156+
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
157+
it.skip('should not execute dynamic source phase imports', async () => {
156158
const { code, stderr, stdout } = await spawnPromisified(execPath, [
157159
'--no-warnings',
158160
'--experimental-wasm-modules',
@@ -166,7 +168,8 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
166168
strictEqual(code, 0);
167169
});
168170

169-
it('should throw for dynamic source phase imports not defined', async () => {
171+
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
172+
it.skip('should throw for dynamic source phase imports not defined', async () => {
170173
const fileUrl = fixtures.fileURL('es-modules/wasm-source-phase.js');
171174
const { code, stderr, stdout } = await spawnPromisified(execPath, [
172175
'--no-warnings',
@@ -222,7 +225,8 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
222225
notStrictEqual(code, 0);
223226
});
224227

225-
it('should throw for vm source phase dynamic import', async () => {
228+
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
229+
it.skip('should throw for vm source phase dynamic import', async () => {
226230
const { code, stderr, stdout } = await spawnPromisified(execPath, [
227231
'--no-warnings',
228232
'--experimental-wasm-modules',

0 commit comments

Comments
 (0)