File tree Expand file tree Collapse file tree 2 files changed +26
-4
lines changed Expand file tree Collapse file tree 2 files changed +26
-4
lines changed Original file line number Diff line number Diff line change @@ -14,12 +14,18 @@ const message = 'Please add a skipIfInspectorDisabled() call to allow this ' +
1414new RuleTester ( ) . run ( 'inspector-check' , rule , {
1515 valid : [
1616 'foo;' ,
17- 'common.skipIfInspectorDisabled(); require("inspector");'
17+ 'require("common")\n' +
18+ 'common.skipIfInspectorDisabled();\n' +
19+ 'require("inspector")'
1820 ] ,
1921 invalid : [
2022 {
21- code : 'require("inspector")' ,
22- errors : [ { message } ]
23+ code : 'require("common")\n' +
24+ 'require("inspector")' ,
25+ errors : [ { message } ] ,
26+ output : 'require("common")\n' +
27+ 'common.skipIfInspectorDisabled();\n' +
28+ 'require("inspector")'
2329 }
2430 ]
2531} ) ;
Original file line number Diff line number Diff line change @@ -15,12 +15,17 @@ const msg = 'Please add a skipIfInspectorDisabled() call to allow this ' +
1515
1616module . exports = function ( context ) {
1717 const missingCheckNodes = [ ] ;
18+ var commonModuleNode = null ;
1819 var hasInspectorCheck = false ;
1920
2021 function testInspectorUsage ( context , node ) {
2122 if ( utils . isRequired ( node , [ 'inspector' ] ) ) {
2223 missingCheckNodes . push ( node ) ;
2324 }
25+
26+ if ( utils . isCommonModule ( node ) ) {
27+ commonModuleNode = node ;
28+ }
2429 }
2530
2631 function checkMemberExpression ( context , node ) {
@@ -32,7 +37,18 @@ module.exports = function(context) {
3237 function reportIfMissing ( context ) {
3338 if ( ! hasInspectorCheck ) {
3439 missingCheckNodes . forEach ( ( node ) => {
35- context . report ( node , msg ) ;
40+ context . report ( {
41+ node,
42+ message : msg ,
43+ fix : ( fixer ) => {
44+ if ( commonModuleNode ) {
45+ return fixer . insertTextAfter (
46+ commonModuleNode ,
47+ '\ncommon.skipIfInspectorDisabled();'
48+ ) ;
49+ }
50+ }
51+ } ) ;
3652 } ) ;
3753 }
3854 }
You can’t perform that action at this time.
0 commit comments