inspector: allow opening inspector when NODE_V8_COVERAGE is set

PR-URL: #46113
Fixes: #46110
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: MoLow

src/inspector_js_api.cc

@@ -272,7 +272,7 @@ static void RegisterAsyncHookWrapper(const FunctionCallbackInfo<Value>& args) {
 
 void IsEnabled(const FunctionCallbackInfo<Value>& args) {
   Environment* env = Environment::GetCurrent(args);
-  args.GetReturnValue().Set(InspectorEnabled(env));
+  args.GetReturnValue().Set(env->inspector_agent()->IsListening());
 }
 
 void Open(const FunctionCallbackInfo<Value>& args) {

test/fixtures/inspector-open.js

@@ -0,0 +1,14 @@
+const assert = require('assert');
+const inspector = require('inspector');
+
+
+assert.strictEqual(inspector.url(), undefined);
+inspector.open(0, undefined, false);
+assert(inspector.url().startsWith('ws://'));
+assert.throws(() => {
+  inspector.open(0, undefined, false);
+}, {
+  code: 'ERR_INSPECTOR_ALREADY_ACTIVATED'
+});
+inspector.close();
+assert.strictEqual(inspector.url(), undefined);

test/parallel/test-inspector-open-coverage.js

@@ -0,0 +1,21 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+const { spawnSync } = require('child_process');
+const fixtures = require('../common/fixtures');
+const tmpdir = require('../common/tmpdir');
+
+common.skipIfInspectorDisabled();
+common.skipIfWorker();
+
+tmpdir.refresh();
+
+
+let output = spawnSync(process.execPath, [fixtures.path('inspector-open.js')]);
+assert.strictEqual(output.status, 0);
+
+output = spawnSync(process.execPath, [fixtures.path('inspector-open.js')], {
+  env: { ...process.env, NODE_V8_COVERAGE: tmpdir.path },
+});
+assert.strictEqual(output.status, 0);