File tree Expand file tree Collapse file tree 1 file changed +4
-3
lines changed Expand file tree Collapse file tree 1 file changed +4
-3
lines changed Original file line number Diff line number Diff line change @@ -137,8 +137,8 @@ notes about [commit squashing](#commit-squashing)).
137137A good commit message should describe what changed and why.
138138
1391391 . The first line should:
140- - contain a short description of the change (preferably 50 characters or less,
141- and no more than 72 characters)
140+ - contain a short description of the change (preferably 50 characters or
141+ less, and no more than 72 characters)
142142 - be entirely in lowercase with the exception of proper nouns, acronyms, and
143143 the words that refer to code, like function/variable names
144144 - be prefixed with the name of the changed subsystem and start with an
@@ -456,7 +456,8 @@ Focus first on the most significant aspects of the change:
4564561 . Does this change make sense for Node.js?
4574572 . Does this change make Node.js better, even if only incrementally?
4584583 . Are there clear bugs or larger scale issues that need attending to?
459- 4 . Is the commit message readable and correct? If it contains a breaking change is it clear enough?
459+ 4 . Is the commit message readable and correct? If it contains a breaking change
460+ is it clear enough?
460461
461462When changes are necessary, * request* them, do not * demand* them, and do not
462463assume that the submitter already knows how to add a test or run a benchmark.
You can’t perform that action at this time.
0 commit comments