Skip to content

Commit 6421a9c

Browse files
0xparasharMylesBorins
0xparashar
authored and
MylesBorins
committed
test: remove unused arguments from function
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexey Orlenko <[email protected]>
1 parent e187c98 commit 6421a9c

File tree

1 file changed

+16
-29
lines changed

1 file changed

+16
-29
lines changed

‎test/parallel/test-http-parser.js‎

Lines changed: 16 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function newParser(type) {
5252
parser.url += url;
5353
};
5454

55-
parser[kOnHeadersComplete] = function(info) {
55+
parser[kOnHeadersComplete] = function() {
5656
};
5757

5858
parser[kOnBody] = common.mustNotCall('kOnBody should not be called');
@@ -94,8 +94,7 @@ function expectBody(expected) {
9494
const request = Buffer.from('GET /hello HTTP/1.1\r\n\r\n');
9595

9696
const onHeadersComplete = (versionMajor, versionMinor, headers,
97-
method, url, statusCode, statusMessage,
98-
upgrade, shouldKeepAlive) => {
97+
method, url) => {
9998
assert.strictEqual(versionMajor, 1);
10099
assert.strictEqual(versionMinor, 1);
101100
assert.strictEqual(method, methods.indexOf('GET'));
@@ -111,7 +110,7 @@ function expectBody(expected) {
111110
// thrown from parser.execute()
112111
//
113112

114-
parser[kOnHeadersComplete] = function(info) {
113+
parser[kOnHeadersComplete] = function() {
115114
throw new Error('hello world');
116115
};
117116

@@ -136,8 +135,7 @@ function expectBody(expected) {
136135
);
137136

138137
const onHeadersComplete = (versionMajor, versionMinor, headers,
139-
method, url, statusCode, statusMessage,
140-
upgrade, shouldKeepAlive) => {
138+
method, url, statusCode, statusMessage) => {
141139
assert.strictEqual(method, undefined);
142140
assert.strictEqual(versionMajor, 1);
143141
assert.strictEqual(versionMinor, 1);
@@ -165,8 +163,7 @@ function expectBody(expected) {
165163
'HTTP/1.0 200 Connection established\r\n\r\n');
166164

167165
const onHeadersComplete = (versionMajor, versionMinor, headers,
168-
method, url, statusCode, statusMessage,
169-
upgrade, shouldKeepAlive) => {
166+
method, url, statusCode, statusMessage) => {
170167
assert.strictEqual(versionMajor, 1);
171168
assert.strictEqual(versionMinor, 0);
172169
assert.strictEqual(method, undefined);
@@ -199,15 +196,14 @@ function expectBody(expected) {
199196

200197
let seen_body = false;
201198

202-
const onHeaders = (headers, url) => {
199+
const onHeaders = (headers) => {
203200
assert.ok(seen_body); // trailers should come after the body
204201
assert.deepStrictEqual(headers,
205202
['Vary', '*', 'Content-Type', 'text/plain']);
206203
};
207204

208205
const onHeadersComplete = (versionMajor, versionMinor, headers,
209-
method, url, statusCode, statusMessage,
210-
upgrade, shouldKeepAlive) => {
206+
method, url) => {
211207
assert.strictEqual(method, methods.indexOf('POST'));
212208
assert.strictEqual(url || parser.url, '/it');
213209
assert.strictEqual(versionMajor, 1);
@@ -242,8 +238,7 @@ function expectBody(expected) {
242238
);
243239

244240
const onHeadersComplete = (versionMajor, versionMinor, headers,
245-
method, url, statusCode, statusMessage,
246-
upgrade, shouldKeepAlive) => {
241+
method) => {
247242
assert.strictEqual(method, methods.indexOf('GET'));
248243
assert.strictEqual(versionMajor, 1);
249244
assert.strictEqual(versionMinor, 0);
@@ -272,8 +267,7 @@ function expectBody(expected) {
272267
);
273268

274269
const onHeadersComplete = (versionMajor, versionMinor, headers,
275-
method, url, statusCode, statusMessage,
276-
upgrade, shouldKeepAlive) => {
270+
method, url) => {
277271
assert.strictEqual(method, methods.indexOf('GET'));
278272
assert.strictEqual(url || parser.url, '/foo/bar/baz?quux=42#1337');
279273
assert.strictEqual(versionMajor, 1);
@@ -307,8 +301,7 @@ function expectBody(expected) {
307301
);
308302

309303
const onHeadersComplete = (versionMajor, versionMinor, headers,
310-
method, url, statusCode, statusMessage,
311-
upgrade, shouldKeepAlive) => {
304+
method, url) => {
312305
assert.strictEqual(method, methods.indexOf('POST'));
313306
assert.strictEqual(url || parser.url, '/it');
314307
assert.strictEqual(versionMajor, 1);
@@ -346,8 +339,7 @@ function expectBody(expected) {
346339
);
347340

348341
const onHeadersComplete = (versionMajor, versionMinor, headers,
349-
method, url, statusCode, statusMessage,
350-
upgrade, shouldKeepAlive) => {
342+
method, url) => {
351343
assert.strictEqual(method, methods.indexOf('POST'));
352344
assert.strictEqual(url || parser.url, '/it');
353345
assert.strictEqual(versionMajor, 1);
@@ -385,8 +377,7 @@ function expectBody(expected) {
385377
);
386378

387379
const onHeadersComplete = (versionMajor, versionMinor, headers,
388-
method, url, statusCode, statusMessage,
389-
upgrade, shouldKeepAlive) => {
380+
method, url) => {
390381
assert.strictEqual(method, methods.indexOf('POST'));
391382
assert.strictEqual(url || parser.url, '/it');
392383
assert.strictEqual(versionMajor, 1);
@@ -445,8 +436,7 @@ function expectBody(expected) {
445436

446437
function test(a, b) {
447438
const onHeadersComplete = (versionMajor, versionMinor, headers,
448-
method, url, statusCode, statusMessage,
449-
upgrade, shouldKeepAlive) => {
439+
method, url) => {
450440
assert.strictEqual(method, methods.indexOf('POST'));
451441
assert.strictEqual(url || parser.url, '/helpme');
452442
assert.strictEqual(versionMajor, 1);
@@ -503,8 +493,7 @@ function expectBody(expected) {
503493
);
504494

505495
const onHeadersComplete = (versionMajor, versionMinor, headers,
506-
method, url, statusCode, statusMessage,
507-
upgrade, shouldKeepAlive) => {
496+
method, url) => {
508497
assert.strictEqual(method, methods.indexOf('POST'));
509498
assert.strictEqual(url || parser.url, '/it');
510499
assert.strictEqual(versionMajor, 1);
@@ -557,8 +546,7 @@ function expectBody(expected) {
557546
);
558547

559548
const onHeadersComplete1 = (versionMajor, versionMinor, headers,
560-
method, url, statusCode, statusMessage,
561-
upgrade, shouldKeepAlive) => {
549+
method, url) => {
562550
assert.strictEqual(method, methods.indexOf('PUT'));
563551
assert.strictEqual(url, '/this');
564552
assert.strictEqual(versionMajor, 1);
@@ -569,8 +557,7 @@ function expectBody(expected) {
569557
};
570558

571559
const onHeadersComplete2 = (versionMajor, versionMinor, headers,
572-
method, url, statusCode, statusMessage,
573-
upgrade, shouldKeepAlive) => {
560+
method, url) => {
574561
assert.strictEqual(method, methods.indexOf('POST'));
575562
assert.strictEqual(url, '/that');
576563
assert.strictEqual(versionMajor, 1);

0 commit comments

Comments
 (0)