src: remove .h if -inl.h is already included

danbev · targos · commit 466601f47f59 · 2018-07-14T14:18:40.000+02:00
This commit removes the normal header file include if an internal one is specified as per the CPP_STYLE_GUIDE. PR-URL: #21381 Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc
@@ -1,5 +1,4 @@
 #include "node.h"
-#include "env.h"
 #include "env-inl.h"
 #include "node_internals.h"
 #include "v8.h"
diff --git a/src/callback_scope.cc b/src/callback_scope.cc
@@ -1,7 +1,5 @@
 #include "node.h"
-#include "async_wrap.h"
 #include "async_wrap-inl.h"
-#include "env.h"
 #include "env-inl.h"
 #include "v8.h"
 
diff --git a/src/exceptions.cc b/src/exceptions.cc
@@ -1,8 +1,6 @@
 #include "node.h"
 #include "node_internals.h"
-#include "env.h"
 #include "env-inl.h"
-#include "util.h"
 #include "util-inl.h"
 #include "v8.h"
 #include "uv.h"
diff --git a/src/node_encoding.cc b/src/node_encoding.cc
@@ -1,8 +1,6 @@
 #include "node.h"
-#include "env.h"
 #include "env-inl.h"
 #include "string_bytes.h"
-#include "util.h"
 #include "util-inl.h"
 #include "v8.h"
 
diff --git a/src/node_platform.cc b/src/node_platform.cc
@@ -1,7 +1,6 @@
 #include "node_platform.h"
 #include "node_internals.h"
 
-#include "env.h"
 #include "env-inl.h"
 #include "util.h"
 #include <algorithm>
diff --git a/src/node_process.cc b/src/node_process.cc
@@ -1,8 +1,6 @@
 #include "node.h"
 #include "node_internals.h"
-#include "env.h"
 #include "env-inl.h"
-#include "util.h"
 #include "util-inl.h"
 #include "uv.h"
 #include "v8.h"

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`#include "node.h"`
`2`		`-#include "env.h"`
`3`	`2`	`#include "env-inl.h"`
`4`	`3`	`#include "node_internals.h"`
`5`	`4`	`#include "v8.h"`