src: remove extra copy from Copy() in node_url.cc

addaleax · MylesBorins · commit 4570fa16c74e · 2017-09-12T03:17:04.000+02:00
The was copying the whole array and the strings in it without any benefit. PR-URL: #14907 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -1007,7 +1007,7 @@ static inline void Copy(Environment* env,
 }
 
 static inline Local<Array> Copy(Environment* env,
-                                std::vector<std::string> vec) {
+                                const std::vector<std::string>& vec) {
   Isolate* isolate = env->isolate();
   Local<Array> ary = Array::New(isolate, vec.size());
   for (size_t n = 0; n < vec.size(); n++)

Original file line number	Diff line number	Diff line change
`@@ -1007,7 +1007,7 @@ static inline void Copy(Environment* env,`
`1007`	`1007`	`}`
`1008`	`1008`
`1009`	`1009`	`static inline Local<Array> Copy(Environment* env,`
`1010`		`- std::vector<std::string> vec) {`
	`1010`	`+ const std::vector<std::string>& vec) {`
`1011`	`1011`	`Isolate* isolate = env->isolate();`
`1012`	`1012`	`Local<Array> ary = Array::New(isolate, vec.size());`
`1013`	`1013`	`for (size_t n = 0; n < vec.size(); n++)`