Skip to content

Commit 23de46c

Browse files
committed
Avoid using auto for easy-to-mix up cases
1 parent e09284b commit 23de46c

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/loader/module_wrap.cc

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ ModuleWrap::ModuleWrap(Environment* env,
4848
}
4949

5050
ModuleWrap::~ModuleWrap() {
51-
auto module = module_.Get(Isolate::GetCurrent());
52-
auto same_hash = module_map_[module->GetIdentityHash()];
51+
Local<Module> module = module_.Get(Isolate::GetCurrent());
52+
std::vector<ModuleWrap*>* same_hash = module_map_[module->GetIdentityHash()];
5353
auto it = std::find(same_hash->begin(), same_hash->end(), this);
5454

5555
if (it != same_hash->end()) {
@@ -152,8 +152,8 @@ void ModuleWrap::Link(const FunctionCallbackInfo<Value>& args) {
152152
Local<Module> mod(obj->module_.Get(iso));
153153

154154
// call the dependency resolve callbacks
155-
for (auto i = 0; i < mod->GetModuleRequestsLength(); i++) {
156-
auto specifier = mod->GetModuleRequest(i);
155+
for (int i = 0; i < mod->GetModuleRequestsLength(); i++) {
156+
Local<String> specifier = mod->GetModuleRequest(i);
157157
Utf8Value specifier_utf(env->isolate(), specifier);
158158
std::string specifier_std(*specifier_utf, specifier_utf.length());
159159

@@ -221,7 +221,8 @@ MaybeLocal<Module> ModuleWrap::ResolveCallback(Local<Context> context,
221221
return MaybeLocal<Module>();
222222
}
223223

224-
auto possible_deps = ModuleWrap::module_map_[referrer->GetIdentityHash()];
224+
std::vector<ModuleWrap*>* possible_deps =
225+
ModuleWrap::module_map_[referrer->GetIdentityHash()];
225226
ModuleWrap* dependent = nullptr;
226227

227228
for (auto possible_dep : *possible_deps) {
@@ -358,7 +359,7 @@ URL resolve_extensions(URL search, bool check_exact = true) {
358359
}
359360
}
360361
for (auto extension : EXTENSIONS) {
361-
auto guess = URL(search.path() + extension, &search);
362+
URL guess(search.path() + extension, &search);
362363
auto check = check_file(guess, true);
363364
if (!check.failed) {
364365
return guess;

0 commit comments

Comments
 (0)