async_wrap: fix memory leak in AsyncResource

mhdawson · addaleax · commit 1248ce1645bb · 2018-05-14T18:32:11.000+02:00
Reset the persistent that keeps the resource Object alive when the AsyncResource is being destroyed. Fixes: nodejs/node-addon-api#237 PR-URL: #20668 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node.h b/src/node.h
@@ -714,6 +714,7 @@ class AsyncResource {
 
     virtual ~AsyncResource() {
       EmitAsyncDestroy(isolate_, async_context_);
+      resource_.Reset();
     }
 
     v8::MaybeLocal<v8::Value> MakeCallback(

Original file line number	Diff line number	Diff line change
`@@ -714,6 +714,7 @@ class AsyncResource {`
`714`	`714`
`715`	`715`	`virtual ~AsyncResource() {`
`716`	`716`	`EmitAsyncDestroy(isolate_, async_context_);`
	`717`	`+ resource_.Reset();`
`717`	`718`	`}`
`718`	`719`
`719`	`720`	`v8::MaybeLocal<v8::Value> MakeCallback(`