lib: make lazyDOMException more common

PR-URL: #39105
Reviewed-By: Antoine du Hamel <[email protected]>

Author: XadillaX

lib/buffer.js

@@ -75,6 +75,7 @@ const {
 const {
   customInspectSymbol,
   isInsideNodeModules,
+  lazyDOMException,
   normalizeEncoding,
   kIsEncodingSymbol
 } = require('internal/util');
@@ -1208,22 +1209,14 @@ if (internalBinding('config').hasIntl) {
   };
 }
 
-let DOMException;
-
-const lazyInvalidCharError = hideStackFrames((message, name) => {
-  if (DOMException === undefined)
-    DOMException = internalBinding('messaging').DOMException;
-  throw new DOMException('Invalid character', 'InvalidCharacterError');
-});
-
 function btoa(input) {
   // The implementation here has not been performance optimized in any way and
   // should not be.
   // Refs: https://github.com/nodejs/node/pull/38433#issuecomment-828426932
   input = `${input}`;
   for (let n = 0; n < input.length; n++) {
     if (input[n].charCodeAt(0) > 0xff)
-      lazyInvalidCharError();
+      throw lazyDOMException('Invalid character', 'InvalidCharacterError');
   }
   const buf = Buffer.from(input, 'latin1');
   return buf.toString('base64');
@@ -1239,7 +1232,7 @@ function atob(input) {
   input = `${input}`;
   for (let n = 0; n < input.length; n++) {
     if (!kBase64Digits.includes(input[n]))
-      lazyInvalidCharError();
+      throw lazyDOMException('Invalid character', 'InvalidCharacterError');
   }
   return Buffer.from(input, 'base64').toString('latin1');
 }

lib/internal/crypto/aes.js

@@ -36,7 +36,6 @@ const {
   getArrayBufferOrView,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   validateByteLength,
   validateKeyOps,
   validateMaxBufferLength,
@@ -45,6 +44,10 @@ const {
   kKeyObject,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const { PromiseReject } = primordials;
 
 const {

lib/internal/crypto/diffiehellman.js

@@ -47,6 +47,10 @@ const {
   isAnyArrayBuffer,
 } = require('internal/util/types');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const {
   KeyObject,
   InternalCryptoKey,
@@ -66,7 +70,6 @@ const {
   getUsagesUnion,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   toBuf,
   kHandle,
   kKeyObject,

lib/internal/crypto/dsa.js

@@ -44,13 +44,16 @@ const {
   getUsagesUnion,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   normalizeHashName,
   validateKeyOps,
   kKeyObject,
   kHandle,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 function verifyAcceptableDsaKeyUse(name, type, usages) {
   let checkSet;
   switch (type) {

lib/internal/crypto/ec.js

@@ -38,14 +38,17 @@ const {
   getUsagesUnion,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   normalizeHashName,
   validateKeyOps,
   kHandle,
   kKeyObject,
   kNamedCurveAliases,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const {
   generateKeyPair,
 } = require('internal/crypto/keygen');

lib/internal/crypto/hkdf.js

@@ -23,7 +23,6 @@ const { kMaxLength } = require('buffer');
 
 const {
   getArrayBufferOrView,
-  lazyDOMException,
   normalizeHashName,
   toBuf,
   validateByteSource,
@@ -35,6 +34,10 @@ const {
   isKeyObject,
 } = require('internal/crypto/keys');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const {
   isAnyArrayBuffer,
   isArrayBufferView,

lib/internal/crypto/mac.js

@@ -18,14 +18,17 @@ const {
   getHashLength,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   normalizeHashName,
   validateBitLength,
   validateKeyOps,
   kHandle,
   kKeyObject,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const {
   codes: {
     ERR_MISSING_OPTION,

lib/internal/crypto/pbkdf2.js

@@ -25,11 +25,14 @@ const { ERR_MISSING_OPTION } = require('internal/errors').codes;
 const {
   getArrayBufferOrView,
   getDefaultEncoding,
-  lazyDOMException,
   normalizeHashName,
   kKeyObject,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 function pbkdf2(password, salt, iterations, keylen, digest, callback) {
   if (typeof digest === 'function') {
     callback = digest;

lib/internal/crypto/random.js

@@ -27,7 +27,7 @@ const {
 
 const {
   lazyDOMException,
-} = require('internal/crypto/util');
+} = require('internal/util');
 
 const { Buffer, kMaxLength } = require('buffer');
 

lib/internal/crypto/rsa.js

@@ -40,14 +40,17 @@ const {
   getUsagesUnion,
   hasAnyNotIn,
   jobPromise,
-  lazyDOMException,
   normalizeHashName,
   validateKeyOps,
   validateMaxBufferLength,
   kHandle,
   kKeyObject,
 } = require('internal/crypto/util');
 
+const {
+  lazyDOMException,
+} = require('internal/util');
+
 const {
   isUint8Array,
 } = require('internal/util/types');