fixup: tuple had []=

Author: litlighilit

Objects/exceptionsImpl.nim

@@ -86,7 +86,8 @@ proc fromBltinSyntaxError*(e: SyntaxError, fileName: PyStrObject): PyExceptionOb
   excpObj.traceBacks.add (PyObject fileName, PyObject nil, e.lineNo, e.colNo)
   excpObj
 
-proc setString*(e: PyBaseExceptionObject, m: PyStrObject) = e.args[0] = m
+proc setString*(e: PyBaseExceptionObject, m: PyStrObject) =
+  withSetItem e.args, acc: acc[0] = m
 proc setString*(e: PyBaseExceptionObject, m: string) =
   ## `_PyErr_SetString`
   e.setString newPyStr m

Objects/listobject.nim

@@ -66,10 +66,14 @@ template genMutableSequenceMethods*(mapper, unmapper, S, Ele, beforeAppend){.dir
 
   `impl S Magic` iadd, [mutable: write]: self.extend other
 
+  
+  proc `[]=`*(self: `Py S Object`; i: int, v: Ele){.inline.} = self.items[i] = v
+  proc `[]=`*(self: `Py S Object`; i: HSlice, v: seq[Ele]){.inline.} = self.items[i] = v
+
   `impl S Magic` setitem, [mutable: write]:
     if arg1.ofPyIntObject:
       let idx = getIndex(PyIntObject(arg1), self.len)
-      self.items[idx] = arg2.mapper
+      self[idx] = arg2.mapper
       return pyNone
     if ofPySliceObject(arg1):
       let slice = PySliceObject(arg1)
@@ -82,7 +86,7 @@ template genMutableSequenceMethods*(mapper, unmapper, S, Ele, beforeAppend){.dir
         var ls: seq[Ele]
         pyForIn it, iterableToLoop:
           ls.add it.mapper
-        self.items[nslice] = ls
+        self[nslice] = ls
       else:
         let (iterable, nextMethod) = getIterableWithCheck(iterableToLoop)
         if iterable.isThrownException:
@@ -93,7 +97,7 @@ template genMutableSequenceMethods*(mapper, unmapper, S, Ele, beforeAppend){.dir
             break
           if it.isThrownException:
             return it
-          self.items[i] = it.mapper
+          self[i] = it.mapper
       return pyNone
     return newIndexTypeError(newPyAscii"list", arg1)
 

Objects/tupleobjectImpl.nim

@@ -169,7 +169,17 @@ proc hashCollection*[T: PyObject](self: T): Hash =
   self.privateHash = result
   self.setHash = true
 
-proc hash*(self: PyTupleObject): Hash = self.hashCollection 
+proc hash*(self: PyTupleObject): Hash = self.hashCollection
+proc clearhash(self: PyTupleObject){.inline.} =
+  ## used after `[]=` to self.items
+  self.setHash = false
+template withSetitem*(self: PyTupleObject; acc; body) =
+  ## unstable.
+  ## take place of `PyTuple_SetItem`
+  bind clearhash
+  template acc: untyped = self.items
+  body
+  clearhash self
 
 implTupleMagic hash:
   handleHashExc:

Python/bltinmodule/iterobjects.nim

@@ -103,8 +103,9 @@ proc next*(self): PyObject =
   if tuplesize == 0:
     return newStopIterError()
 
-  loopIter(self.ittuple, "zip"):
-    res[i] = item
+  res.withSetitem acc:
+    loopIter(self.ittuple, "zip"):
+      acc[i] = item
   return res
 
 

Python/sysmodule/infos.nim

@@ -35,11 +35,12 @@ template genInfo(pureNameId; qualname: string, docStr; fields; n; doIt){.dirty.}
     retIfExc maye
     let it{.inject.} = PyStructSequenceObject maye
 
-    var pos = 0
-    template SetFlag(flag) =
-      it[pos] = flag
-      pos.inc
-    doIt
+    it.withSetItem acc:
+      var pos = 0
+      template SetFlag(flag) =
+        acc[pos] = flag
+        pos.inc
+      doIt
     it
 
 template genInfo(pureNameId; qualname: string, docStr; fields; doIt){.dirty.} =