Revert bool strictness for graph objects

Author: nickdnk

CHANGELOG.md

@@ -35,7 +35,6 @@
         - `GraphList`
         - `GraphObject`
         - `GraphObjectFactory`
-    - Methods that return `bool|null` now always return `bool` and default to `false` instead.
     - `AccessTokenMetaData`:
         - Removed deprecated `getProperty()` function. Use `getField()`.
         - `getExpiresAt()` and `getIssuedAt()` now return `null` if the underlying data cannot be converted to a timestamp.

src/Facebook/Authentication/AccessTokenMetadata.php

@@ -187,9 +187,9 @@ public function getExpiresAt(): ?DateTime
     /**
      * Whether the access token is still valid or not.
      */
-    public function getIsValid(): bool
+    public function getIsValid(): ?bool
     {
-        return $this->getField('is_valid') ?? false;
+        return $this->getField('is_valid');
     }
 
     /**

src/Facebook/GraphNodes/GraphAlbum.php

@@ -52,9 +52,9 @@ public function getBackdatedTime(): ?DateTime
         return $this->getField('backdated_time');
     }
 
-    public function getCanUpload(): bool
+    public function getCanUpload(): ?bool
     {
-        return (bool)$this->getField('can_upload');
+        return $this->getField('can_upload');
     }
 
     public function getCount(): ?int

src/Facebook/GraphNodes/GraphApplication.php

@@ -72,9 +72,9 @@ public function getAppEventsConfig(): ?GraphApplicationEventsConfig
         return $this->getField('app_events_config');
     }
 
-    public function isAppInstallTracked(): bool
+    public function isAppInstallTracked(): ?bool
     {
-        return (bool)$this->getField('app_install_tracked');
+        return $this->getField('app_install_tracked');
     }
 
     public function getAppName(): ?string
@@ -107,9 +107,9 @@ public function getAuthReferralDefaultActivityPrivacy(): ?string
         return $this->getField('auth_referral_default_activity_privacy');
     }
 
-    public function isAuthReferralEnabled(): bool
+    public function isAuthReferralEnabled(): ?bool
     {
-        return (bool)$this->getField('auth_referral_enabled');
+        return $this->getField('auth_referral_enabled');
     }
 
     /**
@@ -141,9 +141,9 @@ public function getAuthReferralUserPermissions(): ?array
         return $this->getField('auth_referral_user_perms');
     }
 
-    public function isCanvasFluidHeight(): bool
+    public function isCanvasFluidHeight(): ?bool
     {
-        return (bool)$this->getField('canvas_fluid_height');
+        return $this->getField('canvas_fluid_height');
     }
 
     public function getCanvasFluidWidth(): ?int
@@ -171,9 +171,9 @@ public function getCompany(): ?string
         return $this->getField('company');
     }
 
-    public function isConfigurediOSSSO(): bool
+    public function isConfigurediOSSSO(): ?bool
     {
-        return (bool)$this->getField('configured_ios_sso');
+        return $this->getField('configured_ios_sso');
     }
 
     public function getContactEmail(): ?string
@@ -239,14 +239,14 @@ public function getiOSBundleIds(): ?array
         return $this->getField('ios_bundle_id');
     }
 
-    public function iOSSupportsNativeProxyAuthFlow(): bool
+    public function iOSSupportsNativeProxyAuthFlow(): ?bool
     {
-        return (bool)$this->getField('ios_supports_native_proxy_auth_flow');
+        return $this->getField('ios_supports_native_proxy_auth_flow');
     }
 
-    public function iOSSupportsSystemAuth(): bool
+    public function iOSSupportsSystemAuth(): ?bool
     {
-        return (bool)$this->getField('ios_supports_system_auth');
+        return $this->getField('ios_supports_system_auth');
     }
 
     public function getiPadAppStoreId(): ?string
@@ -375,9 +375,9 @@ public function getServerIPWhitelist(): ?string
         return $this->getField('server_ip_whitelist');
     }
 
-    public function isSocialDiscovery(): bool
+    public function isSocialDiscovery(): ?bool
     {
-        return (bool)$this->getField('social_discovery');
+        return $this->getField('social_discovery');
     }
 
     public function getSubcategory(): ?string

src/Facebook/GraphNodes/GraphApplicationEventsConfig.php

@@ -10,13 +10,13 @@ public function getDefaultAteStatus(): ?int
         return $this->getField('default_ate_status');
     }
 
-    public function isAdvertiserIdCollectionEnabled(): bool
+    public function isAdvertiserIdCollectionEnabled(): ?bool
     {
-        return (bool)$this->getField('advertiser_id_collection_enabled');
+        return $this->getField('advertiser_id_collection_enabled');
     }
 
-    public function isEventCollectionEnabled(): bool
+    public function isEventCollectionEnabled(): ?bool
     {
-        return (bool)$this->getField('event_collection_enabled');
+        return $this->getField('event_collection_enabled');
     }
 }

src/Facebook/GraphNodes/GraphEvent.php

@@ -78,9 +78,9 @@ public function getEndTime(): ?DateTime
     /**
      * Returns the `is_date_only` (Whether the event only has a date specified, but no time) as bool if present.
      */
-    public function getIsDateOnly(): bool
+    public function getIsDateOnly(): ?bool
     {
-        return $this->getField('is_date_only') ?? false;
+        return $this->getField('is_date_only');
     }
 
     /**

src/Facebook/GraphNodes/GraphPhoto.php

@@ -43,19 +43,19 @@ public function getBackDatedTime(): ?DateTime
         return $this->getField('backdated_time');
     }
 
-    public function canBackDate(): bool
+    public function canBackDate(): ?bool
     {
-        return (bool)$this->getField('can_backdate');
+        return $this->getField('can_backdate');
     }
 
-    public function canDelete(): bool
+    public function canDelete(): ?bool
     {
-        return (bool)$this->getField('can_delete');
+        return $this->getField('can_delete');
     }
 
-    public function canTag(): bool
+    public function canTag(): ?bool
     {
-        return (bool)$this->getField('can_tag');
+        return $this->getField('can_tag');
     }
 
     public function getCreatedTime(): ?DateTime

src/Facebook/GraphNodes/GraphPicture.php

@@ -33,9 +33,9 @@ class GraphPicture extends GraphNode
     /**
      * Returns true if user picture is silhouette.
      */
-    public function isSilhouette(): bool
+    public function isSilhouette(): ?bool
     {
-        return $this->getField('is_silhouette') ?? false;
+        return $this->getField('is_silhouette');
     }
 
     /**

src/Facebook/GraphNodes/GraphSessionInfo.php

@@ -59,9 +59,9 @@ public function getExpiresAt(): ?DateTime
     /**
      * Returns whether the token is valid.
      */
-    public function getIsValid(): bool
+    public function getIsValid(): ?bool
     {
-        return $this->getField('is_valid') ?? false;
+        return $this->getField('is_valid');
     }
 
     /**

src/Facebook/GraphNodes/GraphUser.php

@@ -191,19 +191,19 @@ public function getPicture(): ?GraphPicture
         return $this->getField('picture');
     }
 
-    public function supportsDonateButtonInLiveVideos(): bool
+    public function supportsDonateButtonInLiveVideos(): ?bool
     {
-        return (bool)$this->getField('supports_donate_button_in_live_video');
+        return $this->getField('supports_donate_button_in_live_video');
     }
 
     public function getAgeRange(): ?GraphAgeRange
     {
         return $this->getField('age_range');
     }
 
-    public function isInstalled(): bool
+    public function isInstalled(): ?bool
     {
-        return (bool)$this->getField('installed');
+        return $this->getField('installed');
     }
 
     /**