refactor: Remove extra Hashable conformance for ParseObject (#182)

* fix: Remove extra Hashable conformance for ParseObject

* remove more double conformance

* make public version of encoding ParseObject

* remove public encoder

* use xcbeautify in CI

* Update ci.yml

* doc nits

* Update ci.yml

* Update ci.yml

* test not running installation tests on Windows

* disable more windows using Installation

* revert testing windows

* Update ci.yml

Author: cbaker6

.github/workflows/ci.yml

@@ -37,7 +37,7 @@ jobs:
             action: 'test'
     steps:
     - uses: actions/checkout@v4
-    - name: Install SwiftLint
+    - name: Install Extra Packages
       run: brew install swiftlint
     - name: Create and set the default keychain
       run: |
@@ -46,7 +46,7 @@ jobs:
         security unlock-keychain -p "" temporary
         security set-keychain-settings -lut 7200 temporary
     - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace Parse.xcworkspace -scheme ParseSwift -derivedDataPath DerivedData -destination ${{ matrix.destination }} ${{ matrix.action }} | xcpretty -c
+      run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace Parse.xcworkspace -scheme ParseSwift -derivedDataPath DerivedData -destination ${{ matrix.destination }} ${{ matrix.action }} 2>&1 | xcbeautify --renderer github-actions
       env:
           DEVELOPER_DIR: ${{ env.CI_XCODE_LATEST }}
     - name: Prepare codecov
@@ -80,7 +80,7 @@ jobs:
     - name: Install SwiftLint
       run: brew install swiftlint
     - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES swift test --enable-code-coverage | xcpretty -c
+      run: set -o pipefail && env NSUnbufferedIO=YES swift test --enable-code-coverage 2>&1 | xcbeautify --renderer github-actions
       env:
           DEVELOPER_DIR: ${{ env.CI_XCODE_LATEST }}
     - name: Prepare codecov
@@ -108,7 +108,7 @@ jobs:
     steps:
     - uses: actions/checkout@v4
     - name: Build-Test
-      run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace Parse.xcworkspace -scheme ParseSwift -destination platform\=iOS\ Simulator,name\=iPhone\ 13\ Pro\ Max -derivedDataPath DerivedData build | xcpretty -c
+      run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -workspace Parse.xcworkspace -scheme ParseSwift -destination platform\=iOS\ Simulator,name\=iPhone\ 13\ Pro\ Max -derivedDataPath DerivedData build 2>&1 | xcbeautify --renderer github-actions
       env:
           DEVELOPER_DIR: ${{ env.CI_XCODE_OLDEST }}
 
@@ -141,11 +141,11 @@ jobs:
       - uses: actions/checkout@v4
       - uses: compnerd/[email protected]
         with:
-          branch: swift-5.10-release
-          tag: 5.10-RELEASE
+          branch: swift-5.10.1-release
+          tag: 5.10.1-RELEASE
       - name: Build
         run: |
-          swift build -v
+          swift build --enable-test-discovery -v
       - name: Upload coverage to Codecov
         uses: codecov/codecov-action@v4
         with:

CHANGELOG.md

@@ -2,9 +2,15 @@
 # Parse-Swift Changelog
 
 ### main
-[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.11.2...main), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/main/documentation/parseswift)
+[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.11.3...main), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/main/documentation/parseswift)
 * _Contributing to this repo? Add info about your change here to be included in the next release_
 
+### 5.11.3
+[Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.11.2...5.11.3), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/5.11.3/documentation/parseswift)
+
+__Fixes__
+* Remove all double conformance of Hashable and Equatable ([#182](https://github.com/netreconlab/Parse-Swift/pull/182)), thanks to [Corey Baker](https://github.com/cbaker6).
+
 ### 5.11.2
 [Full Changelog](https://github.com/netreconlab/Parse-Swift/compare/5.11.1...5.11.2), [Documentation](https://swiftpackageindex.com/netreconlab/Parse-Swift/5.11.2/documentation/parseswift)
 

Sources/ParseSwift/API/API+NonParseBodyCommand.swift

@@ -145,7 +145,7 @@ internal extension API.NonParseBodyCommand {
                       objectsSavedBeforeThisOne: [String: PointerType]?,
                       // swiftlint:disable:next line_length
                       filesSavedBeforeThisOne: [String: ParseFile]?) async throws -> RESTBatchCommandTypeEncodablePointer<AnyCodable> {
-        try await yieldIfNotInitialized()
+
         let defaultACL = try? await ParseACL.defaultACL()
         let batchCommands = try objects.compactMap { (object) -> API.BatchCommand<AnyCodable, PointerType>? in
             guard var objectable = object as? Objectable else {

Sources/ParseSwift/Coding/ParseEncoder.swift

@@ -50,9 +50,11 @@ extension Dictionary: _JSONStringDictionaryEncodableMarker where Key == String,
 /** An object that encodes Parse instances of a data type as JSON objects.
  - note: `JSONEncoder` facilitates the encoding of `Encodable` values into JSON.
  `ParseEncoder` facilitates the encoding of `ParseEncodable` values into JSON.
- All Credit to Apple, this is a custom encoder with capability of skipping keys at runtime.
- ParseEncoder matches the features of the [Swift 5.4 JSONEncoder ](https://github.com/apple/swift/blob/main/stdlib/public/Darwin/Foundation/JSONEncoder.swift).
- Update commits as needed for improvement.
+ All Credit to Apple for the baseline encoder. The `ParseEncoder` is a custom encoder
+ with capability of skipping keys at runtime and encoding objects into a digestable format
+ for a [parse-server](https://github.com/parse-community/parse-server).
+ `ParseEncoder` matches the features of the [Swift 5.4 JSONEncoder ](https://github.com/apple/swift/blob/main/stdlib/public/Darwin/Foundation/JSONEncoder.swift).
+ Update comments as needed for improvement.
  */
 public struct ParseEncoder: Sendable {
     let dateEncodingStrategy: JSONEncoder.DateEncodingStrategy?
@@ -109,11 +111,13 @@ public struct ParseEncoder: Sendable {
         self.outputFormatting = outputFormatting
     }
 
-    func encode(_ value: Encodable,
-                acl: ParseACL? = nil,
-                batching: Bool = false,
-                objectsSavedBeforeThisOne: [String: PointerType]? = nil,
-                filesSavedBeforeThisOne: [String: ParseFile]? = nil) throws -> Data {
+    func encode(
+        _ value: Encodable,
+        acl: ParseACL? = nil,
+        batching: Bool = false,
+        objectsSavedBeforeThisOne: [String: PointerType]? = nil,
+        filesSavedBeforeThisOne: [String: ParseFile]? = nil
+    ) throws -> Data {
         var keysToSkip = SkipKeys.none.keys()
         if batching {
             keysToSkip = SkipKeys.object.keys()
@@ -137,53 +141,76 @@ public struct ParseEncoder: Sendable {
     /**
      Encodes an instance of the indicated `ParseEncodable`.
      - parameter value: The `ParseEncodable` instance to encode.
+     - parameter acl: The `ParseACL` to add to the value if it is an `ParseObject`. Defaults to `nil`.
      - parameter skipKeys: The set of keys to skip during encoding.
      */
-    public func encode<T: ParseEncodable>(_ value: T,
-                                          acl: ParseACL? = nil,
-                                          skipKeys: SkipKeys) throws -> Data {
-        let encoder = _ParseEncoder(codingPath: [], dictionary: NSMutableDictionary(), skippingKeys: skipKeys.keys())
+    public func encode<T: ParseEncodable>(
+        _ value: T,
+        acl: ParseACL? = nil,
+        skipKeys: SkipKeys
+    ) throws -> Data {
+        let encoder = _ParseEncoder(
+            codingPath: [],
+            dictionary: NSMutableDictionary(),
+            skippingKeys: skipKeys.keys()
+        )
         if let dateEncodingStrategy = dateEncodingStrategy {
             encoder.dateEncodingStrategy = dateEncodingStrategy
         }
         if let outputFormatting = outputFormatting {
             encoder.outputFormatting = outputFormatting
         }
-        return try encoder.encodeObject(value,
-                                        acl: acl,
-                                        collectChildren: false,
-                                        uniquePointer: nil,
-                                        objectsSavedBeforeThisOne: nil,
-                                        filesSavedBeforeThisOne: nil).encoded
+        let encodedData = try encoder.encodeObject(
+            value,
+            acl: acl,
+            collectChildren: false,
+            uniquePointer: nil,
+            objectsSavedBeforeThisOne: nil,
+            filesSavedBeforeThisOne: nil
+        ).encoded
+
+        return encodedData
     }
 
     // swiftlint:disable large_tuple
-    internal func encode<T: ParseObject>(_ value: T,
-                                         acl: ParseACL? = nil,
-                                         collectChildren: Bool,
-                                         objectsSavedBeforeThisOne: [String: PointerType]?,
-                                         filesSavedBeforeThisOne: [String: ParseFile]?) throws -> (encoded: Data,
-                                                                                                   unique: PointerType?,
-                                                                                                   unsavedChildren: [Encodable]) {
+    func encode<T: ParseObject>(
+        _ value: T,
+        acl: ParseACL? = nil,
+        collectChildren: Bool,
+        objectsSavedBeforeThisOne: [String: PointerType]?,
+        filesSavedBeforeThisOne: [String: ParseFile]?
+    ) throws -> (
+        encoded: Data,
+        unique: PointerType?,
+        unsavedChildren: [Encodable]
+    ) {
         let keysToSkip: Set<String>!
         if !Parse.configuration.isRequiringCustomObjectIds {
             keysToSkip = SkipKeys.object.keys()
         } else {
             keysToSkip = SkipKeys.customObjectId.keys()
         }
-        let encoder = _ParseEncoder(codingPath: [], dictionary: NSMutableDictionary(), skippingKeys: keysToSkip)
+        let encoder = _ParseEncoder(
+            codingPath: [],
+            dictionary: NSMutableDictionary(),
+            skippingKeys: keysToSkip
+        )
         if let dateEncodingStrategy = dateEncodingStrategy {
             encoder.dateEncodingStrategy = dateEncodingStrategy
         }
         if let outputFormatting = outputFormatting {
             encoder.outputFormatting = outputFormatting
         }
-        return try encoder.encodeObject(value,
-                                        acl: acl,
-                                        collectChildren: collectChildren,
-                                        uniquePointer: try? value.toPointer(),
-                                        objectsSavedBeforeThisOne: objectsSavedBeforeThisOne,
-                                        filesSavedBeforeThisOne: filesSavedBeforeThisOne)
+        let encodedObject = try encoder.encodeObject(
+            value,
+            acl: acl,
+            collectChildren: collectChildren,
+            uniquePointer: try? value.toPointer(),
+            objectsSavedBeforeThisOne: objectsSavedBeforeThisOne,
+            filesSavedBeforeThisOne: filesSavedBeforeThisOne
+        )
+
+        return encodedObject
     }
 
     internal func encode(_ value: ParseEncodable,

Sources/ParseSwift/LiveQuery/LiveQueryConstants.swift

@@ -16,7 +16,7 @@ import Foundation
  - Updated: The object has been updated, and is still a part of the query.
  - Deleted: The object has been deleted, and is no longer included in the query.
  */
-public enum Event<T: ParseObject>: Equatable {
+public enum Event<T: ParseObject>: Equatable, Sendable {
     /// The object has been updated, and is now included in the query.
     case entered(T)
 

Sources/ParseSwift/LiveQuery/Operations.swift

@@ -26,6 +26,6 @@ enum OperationErrorResponse: String, Codable {
 
 // An opaque placeholder structed used to ensure that we type-safely create request IDs and do not shoot ourself in
 // the foot with array indexes.
-struct RequestId: Hashable, Equatable, Codable {
+struct RequestId: Hashable, Codable {
     let value: Int
 }

Sources/ParseSwift/Objects/ParseObject.swift

@@ -44,8 +44,7 @@ public protocol ParseObject: ParseTypeable,
                              Fetchable,
                              Savable,
                              Deletable,
-                             Identifiable,
-                             Hashable {
+                             Identifiable {
 
     /**
      A JSON encoded version of this `ParseObject` before `.set()` or

Sources/ParseSwift/ParseConstants.swift

@@ -10,7 +10,7 @@ import Foundation
 
 enum ParseConstants {
     static let sdk = "swift"
-    static let version = "5.11.2"
+    static let version = "5.11.3"
     static let fileManagementDirectory = "parse/"
     static let fileManagementPrivateDocumentsDirectory = "Private Documents/"
     static let fileManagementLibraryDirectory = "Library/"

Sources/ParseSwift/Protocols/ParseConfig.swift

@@ -94,12 +94,12 @@ extension ParseConfig {
     }
 }
 
-internal struct ConfigUpdateBody<T>: ParseTypeable, Decodable where T: ParseConfig {
+internal struct ConfigUpdateBody<T>: ParseTypeable where T: ParseConfig {
     let params: T
 }
 
 // MARK: Current
-struct CurrentConfigContainer<T: ParseConfig>: Codable, Equatable {
+struct CurrentConfigContainer<T: ParseConfig>: Codable, Hashable {
     var currentConfig: T?
 }
 

Sources/ParseSwift/Protocols/ParsePointerable.swift

@@ -29,7 +29,7 @@ extension ParsePointer {
     }
 }
 
-public protocol ParsePointerObject: ParsePointer, ParseTypeable, Fetchable, Hashable {
+public protocol ParsePointerObject: ParsePointer, ParseTypeable, Fetchable {
     associatedtype Object: ParseObject
 }