Reduce scope of 'installable' test #483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
aitchiss
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst implementing accessibility text for the PWA score in App, I noticed "being installable" only depends on one audit, not on multiple like the text description suggests. We're currently checking two – manifest and service worker.
https://github.com/GoogleChrome/lighthouse/blob/main/core/config/default-config.js#L657-L658
The audit grouping confirms having a service worker counts towards being "optimized", but not towards being "installable".
https://github.com/GoogleChrome/lighthouse/blob/main/core/config/default-config.js#L659-L660
This PR reduces the criteria for a report to be classed as installable, hopefully reducing the risk of false negatives