feat: Add support for theme matching and scroll reporting via postMessage
#461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for plugin-lighthouse processing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the existing (but unused) functionality for reading a users theme preference via query parameter.
Instead, we will use
postMessageto communicate cross-origin between the report and the App. We'll be sending a theme preference in one direction, and sending back a message when the scroll reaches the page bottom.This approach has less flexibility than before, in that the theme switching now only works within an iframe (which is fine for current needs). On the plus side, the injection does feel cleaner than the previous iteration as we're now appending a standalone script at the end, rather than injecting mid-function.