fix serve functions.. and correct the root cause of localhost:30001 bug by swyxio · Pull Request #71 · netlify/netlify-dev-plugin · GitHub

This repository was archived by the owner on Sep 12, 2019. It is now read-only.

Contributor

swyxio commented Apr 2, 2019

closes #58

this bug was directly caused because ZISI was expecting a full settings object: https://github.com/netlify/zip-it-and-ship-it/blob/306d26a4b1ff99bfe0ace291755e980040c2b2ae/src/serve.js#L154

but we were only providing an object with functionsDir:

netlify-dev-plugin/src/commands/dev/index.js

Line 149 in b062da4

const fnSettings = await serveFunctions({ functionsDir })

the indirect fix for this is to use typescript to better communicate & enforce contracts.


          fix serve functions.. ugh.

c526e38

swyxio merged commit d947f1a into master

swyxio deleted the fixServeFunctions branch

April 2, 2019 17:20

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet