Merge pull request #90 from netlify/removeDevPort

Remove dev port

Author: swyxio

README.md

@@ -43,7 +43,6 @@ USAGE
 
 OPTIONS
   -c, --cmd=cmd              command to run
-  -d, --devport=devport      port of the dev server started by command
   -f, --functions=functions  Specify a functions folder to serve
   -o, --offline              disables any features that require network access
   -p, --port=port            Specify port of netlify dev

TEST_PLAN.md

@@ -0,0 +1,42 @@
+# test fixtures
+
+## test netlify dev --live
+
+1. CRA
+2. CRA + redirect for SPA
+3. CRA + functions
+4. CRA + redirected functions
+5. Gatsby
+
+## netlify dev
+
+1. netlify dev
+2. netlify dev --port 23
+3. netlify dev --cmd vuepress
+4. netlify dev --offline
+5. netlify dev, with toml, good port
+
+[dev]
+port = 8000 # Port that the dev server will be listening on
+
+6. netlify dev, with toml, bad port
+
+[dev]
+port = 9999 # Port that the dev server will be listening on
+
+7. netlify dev, with toml, \_redirects inside publish
+
+[dev]
+publish = "public"
+
+8. netlify dev, with toml, custom command
+
+[dev]
+command = "yarn start"
+
+9. netlify dev,
+   with custom command in flag, --cmd vuepress,
+   but also custom command in toml (flag should win)
+
+[dev]
+command = "yarn start"

src/commands/dev/index.js

@@ -266,10 +266,6 @@ DevCommand.strict = false;
 
 DevCommand.flags = {
   cmd: flags.string({ char: "c", description: "command to run" }),
-  devport: flags.integer({
-    char: "d",
-    description: "port of the dev server started by command"
-  }),
   port: flags.integer({ char: "p", description: "port of netlify dev" }),
   dir: flags.integer({ char: "d", description: "dir with static files" }),
   functions: flags.string({