feat: implement pktvisor config parser #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Go test coverage
Total coverage: 0.8% |
mfiedorowicz
approved these changes
Mar 7, 2025
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
leoparente
pushed a commit
that referenced
this pull request
Jun 23, 2025
Bumps the go_modules group with 1 update in the /network-discovery directory: [golang.org/x/net](https://github.com/golang/net). Updates `golang.org/x/net` from 0.36.0 to 0.38.0 - [Commits](golang/net@v0.36.0...v0.38.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-version: 0.38.0 dependency-type: indirect dependency-group: go_modules ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
pktvisorbackend in theagentpackage. The key changes involve updating configuration handling, modifying default settings, and improving error handling. Below are the most important changes:Configuration Handling:
Configuremethod, including the conversion of the configuration map to YAML and writing it to the temp file. (agent/backend/pktvisor/pktvisor.go)Default Settings:
defaultConfigPathconstant and updated default settings forhostandportinRegisterBackendSpecificVariables. (agent/backend/pktvisor/pktvisor.go,agent/backend/pktvisor/vars.go) [1] [2]Imports and Dependencies:
fmt,os, andyaml.v3to support the new configuration handling logic. (agent/backend/pktvisor/pktvisor.go)