fix: corrects vault yaml config #175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #174
This pull request improves the handling and testing of YAML serialization and validation for the
AuthAppRole
struct in the Vault authentication code. The main focus is on ensuring that optional fields are correctly omitted from YAML output when empty and that required fields are validated during unmarshaling. Comprehensive unit tests have been added to verify these behaviors.Improvements to YAML serialization and validation
WrappingToken
andMountPath
inAuthAppRole
to use the correctomitempty
option, ensuring empty values are omitted during YAML marshaling.Enhancements to unit testing
vault_auth_test.go
to verify that YAML marshaling omits empty fields and that unmarshaling correctly reconstructs the struct, including edge cases for optional and required fields.role_id
,secret_id
) in the YAML input result in appropriate errors during unmarshaling.Test infrastructure updates
yaml.v3
package to support YAML marshaling and unmarshaling in tests.stringPtr
to simplify pointer creation for test cases.