feat: add dry run mode support to network and snmp discovery #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a dry-run mode for both SNMP and network discovery backends, allowing simulated execution without side effects.
- Added diodeDryRun and diodeDryRunOutputDir configuration fields to the relevant backend structs.
- Modified Configure and Start methods to conditionally build command-line arguments based on the dry-run setting.
- Added unit tests to verify the dry-run behavior in both discovery backends.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agent/backend/snmpdiscovery/snmp_discovery_test.go | Added a unit test for dry-run mode for the SNMP discovery backend (note potential misnaming of the test function). |
| agent/backend/snmpdiscovery/snmp_discovery.go | Updated the SNMP discovery backend to support dry-run mode with conditional command-line option construction. |
| agent/backend/networkdiscovery/network_discovery_test.go | Added a unit test for dry-run mode for the network discovery backend. |
| agent/backend/networkdiscovery/network_discovery.go | Updated the network discovery backend to support dry-run mode with conditional command-line argument construction. |
Comments suppressed due to low confidence (1)
agent/backend/snmpdiscovery/snmp_discovery_test.go:205
- The test function name suggests it is for network discovery, but this file is for the SNMP discovery backend; consider renaming it to TestSNMPDiscoveryBackendDryRun for clarity.
func TestNetworkDiscoveryBackendDryRun(t *testing.T) {
|
Go test coverage
Total coverage: 58.0% |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a "dry-run" mode to the
networkDiscoveryBackendandsnmpDiscoveryBackendcomponents, enabling safer testing by simulating operations without executing them. It also adds corresponding configurations and unit tests to ensure the functionality works as expected.Backend Enhancements:
diodeDryRunanddiodeDryRunOutputDirfields tonetworkDiscoveryBackendandsnmpDiscoveryBackendstructs to support dry-run mode. (agent/backend/networkdiscovery/network_discovery.go: [1]agent/backend/snmpdiscovery/snmp_discovery.go: [2]Configuremethods to populate dry-run-related fields from configuration and handle optional parameters. (agent/backend/networkdiscovery/network_discovery.go: [1]agent/backend/snmpdiscovery/snmp_discovery.go: [2]Startmethods to adjust command-line arguments based on dry-run mode, ensuring safe execution and proper logging. (agent/backend/networkdiscovery/network_discovery.go: [1]agent/backend/snmpdiscovery/snmp_discovery.go: [2]Testing Additions:
networkDiscoveryBackendandsnmpDiscoveryBackend, verifying configuration, startup behavior, and command-line arguments. (agent/backend/networkdiscovery/network_discovery_test.go: [1]agent/backend/snmpdiscovery/snmp_discovery_test.go: [2]