Reintialize page in allocNewBuffer only when buffer is returned

Author: Konstantin Knizhnik

src/backend/access/spgist/spgutils.c

@@ -523,10 +523,10 @@ allocNewBuffer(Relation index, int flags)
 		Buffer		buffer;
 
 		buffer = SpGistNewBuffer(index);
-		SpGistInitBuffer(buffer, pageflags);
 
 		if (pageflags & SPGIST_LEAF)
 		{
+			SpGistInitBuffer(buffer, pageflags);
 			/* Leaf pages have no parity concerns, so just use it */
 			return buffer;
 		}
@@ -537,6 +537,7 @@ allocNewBuffer(Relation index, int flags)
 
 			if ((flags & GBUF_PARITY_MASK) == blkFlags)
 			{
+				SpGistInitBuffer(buffer, pageflags);
 				/* Page has right parity, use it */
 				return buffer;
 			}