Commit 0d977f8
committed
Remove remaining stub tests and dependency on legacy stub server (#1088)
* Remove remaining stub tests and dependency on legacy stub server
Reactive Testkit backend enabled a lot of Testkit tests to run on reactive driver. This update removes dependency on legacy stub server that is no longer maintained.
The remaining stub tests have been removed since there are similar tests in Testkit already, the tests and their respective Testkit alternatives are provided below:
- `DirectDriverBoltKitIT.shouldStreamingRecordsInBatchesRx` -> `TestIterationSessionRun.test_half_batch` - Both test result consumption in batches.
- `DirectDriverBoltKitIT.shouldDiscardIfPullNotFinished` -> `TestIterationSessionRun.test_discards_on_session_close` - Unlike the original, Testkit test consumes one record and discards the rest using session `run` intead of tx function. Based on its name, the original test purpose was to check if discard happens when result stream is not consumed in full and the suggested test covers this.
- `RoutingDriverBoltKitIT.shouldHandleLeaderSwitchAndRetryWhenWritingInTxFunctionRX` -> `RoutingV4x4.test_should_write_successfully_on_leader_switch_using_tx_function` - Both check leader failure handling.
One of examples that dependended on stub server has been brought in line with the rest of examples and uses `DatabaseExtension` to manage server.
* Renamed RoutingDriverBoltKitIT to ResolverIT1 parent a3961b1 commit 0d977f8
File tree
15 files changed
+100
-583
lines changed- driver/src/test
- java/org/neo4j/driver
- integration
- internal
- util
- resources
- examples/src
- main/java/org/neo4j/docs/driver
- test
- java/org/neo4j/docs/driver
- resources
- testkit-backend/src/main/java/neo4j/org/testkit/backend
15 files changed
+100
-583
lines changedLines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | | - | |
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
58 | 63 | | |
59 | 64 | | |
60 | 65 | | |
| |||
Lines changed: 56 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
Lines changed: 0 additions & 129 deletions
This file was deleted.
Lines changed: 0 additions & 95 deletions
This file was deleted.
0 commit comments