fix: some stackTrace handling fix

Author: farfromrefug

src/client.ts

@@ -60,8 +60,6 @@ export class NativescriptClient extends BaseClient<NativescriptClientOptions> {
             // - stack with only the JS error stack
             // stackTrace with a mix of JS/Java error
             exception['stacktrace'] = exception.toString() + '\n at ' + exception['stack'];
-            // console.log('eventFromException', exception['stack']);
-            // console.log('eventFromException1', exception['stackTrace']);
         } else if (exception['stackTrace']) {
             exception['stacktrace'] = exception['stackTrace'];
         }
@@ -73,17 +71,21 @@ export class NativescriptClient extends BaseClient<NativescriptClientOptions> {
             this._options.attachStacktrace,
         );
         if(exception['nativeException'])  {
-            const stack = parseErrorStack({ stack: 'at ' + exception['stackTrace'] } as any).filter(f=>f.platform !== 'javascript');
-            stack.forEach((frame) => rewriteFrameIntegration._iteratee(frame));
-            event.exception.values.unshift({
-                type:'NativeException',
-                value:exception.toString(),
-                stacktrace:{
-                    frames:stack
-                }
-            });
+            try {
+                const stack = parseErrorStack({ stack: 'at ' + exception['stackTrace'] } as any).filter(f=>f.platform !== 'javascript');
+                stack.forEach((frame) => rewriteFrameIntegration._iteratee(frame));
+                event.exception.values.unshift({
+                    type:'NativeException',
+                    value:exception.toString(),
+                    stacktrace:{
+                        frames:stack
+                    }
+                });
+            } catch (error) {
+                console.error(error, error.stack);
+            }
+
         }
-        // event.exception.values.forEach(ex=>console.log('event.exception.values', JSON.stringify(ex.stacktrace.frames.reverse())));
         return event;
         // return this._browserClient.eventFromException(exception, hint);
     }

src/integrations/default.ts

@@ -32,33 +32,35 @@ export let rewriteFrameIntegration: {
  */
 export function getDefaultIntegrations(options: NativescriptClientOptions & NativescriptOptions): Integration[] {
     const integrations: Integration[] = [];
+    const iteratee = (frame: StackFrame) => {
+        if (frame.platform === 'javascript' && frame.filename) {
+            let filename = frame.filename
+                .replace(/^file\:\/\//, '')
+                .replace(/^address at /, '')
+                .replace(/^.*\/[^\.]+(\.app|CodePush|.*(?=\/))/, '');
 
-    rewriteFrameIntegration = new RewriteFrames({
-        iteratee: (frame: StackFrame) => {
-            if (frame.platform === 'javascript' && frame.filename) {
-                let filename = frame.filename
-                    .replace(/^file\:\/\//, '')
-                    .replace(/^address at /, '')
-                    .replace(/^.*\/[^\.]+(\.app|CodePush|.*(?=\/))/, '');
-
-                if (frame.filename.indexOf('[native code]') === -1) {
-                    const appPrefix = options.appPrefix ?? '~/';
-                    if (appPrefix.endsWith('//') && !appPrefix.endsWith('///')) {
-                        filename = filename.indexOf('/') === 0 ? `${appPrefix}${filename}` : `${appPrefix}/${filename}`;
-                    } else {
-                        filename = filename.indexOf('/') === 0 ? `${appPrefix}${filename.slice(1)}` : `${appPrefix}${filename}`;
-                    }
+            if (frame.filename.indexOf('[native code]') === -1) {
+                const appPrefix = options.appPrefix ?? '~/';
+                if (appPrefix.endsWith('//') && !appPrefix.endsWith('///')) {
+                    filename = filename.indexOf('/') === 0 ? `${appPrefix}${filename}` : `${appPrefix}/${filename}`;
+                } else {
+                    filename = filename.indexOf('/') === 0 ? `${appPrefix}${filename.slice(1)}` : `${appPrefix}${filename}`;
                 }
+            }
 
-                frame.filename = filename;
-                if (options.colnoOffset) {
-                    frame.colno += options.colnoOffset;
-                }
-                // We always want to have a tripple slash
+            frame.filename = filename;
+            if (options.colnoOffset) {
+                frame.colno += options.colnoOffset;
             }
-            return frame;
+            // We always want to have a tripple slash
         }
+        return frame;
+    };
+
+    rewriteFrameIntegration = new RewriteFrames({
+
     }) as any;
+    rewriteFrameIntegration._iteratee =iteratee;
 
     // if (notWeb()) {
     integrations.push(

src/sdk.ts

@@ -124,8 +124,9 @@ export function init(passedOptions: NativescriptOptions): void {
       typeof options.tracesSampler !== 'undefined' ||
       typeof options.tracesSampleRate !== 'undefined';
 
+    const DEFAULT_INTEGRATIONS = getDefaultIntegrations(options);
     const defaultIntegrations: false | Integration[] = passedOptions.defaultIntegrations === undefined
-        ? getDefaultIntegrations(options)
+        ? DEFAULT_INTEGRATIONS
         : passedOptions.defaultIntegrations;
     // if (passedOptions.defaultIntegrations === undefined) {
     //     rewriteFrameIntegration = new RewriteFrames({